➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2016-09-06 17:56 byzach.ware, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| deprecate_bundled_libffi.diff | zach.ware,2016-09-06 17:56 | review | ||
| issue27976.diff | zach.ware,2016-09-08 00:04 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg274576 -(view) | Author: Zachary Ware (zach.ware)* | Date: 2016-09-06 17:56 | |
Nosy list copied from#23085.Here's a patch that deprecates building _ctypes with the bundled copy of libffi (Modules/_ctypes/libffi/). The default on all platforms (other than Windows) is now to use a system copy of libffi; use the '--without-system-ffi' flag to ./configure to use the bundled copy. On non-Darwin platforms, a warning will be emitted noting thatModules/_ctypes/libffi will not be distributed with 3.7. | |||
| msg274627 -(view) | Author: Berker Peksag (berker.peksag)* | Date: 2016-09-06 20:56 | |
+1, thanks for working on this!Two questions:1. Should we check the system version of libffi and warn users (and probably use the bundled version for now) if it was older than 3.1?2. I know this isn't directly a user-facing feature, but should we add a short note toDoc/whatsnew/3.6.rst? (we can probably mention that most of the Linux distributions already use --with-system-ffi.) | |||
| msg274628 -(view) | Author: Zachary Ware (zach.ware)* | Date: 2016-09-06 21:06 | |
I don't think it's worthwhile to do a version check and warning, especially since we'll be removing the bundled version in 3.7. A docs note is worthwhile, though, I'll attach a new patch shortly. | |||
| msg274761 -(view) | Author: (yan12125)* | Date: 2016-09-07 05:22 | |
That's great!issue26942 can be closed after this change is landed. It's caused by a libffi bug on Android. | |||
| msg274926 -(view) | Author: Zachary Ware (zach.ware)* | Date: 2016-09-08 00:04 | |
Finally got a new patch created. After talking it over with Ned yesterday, this patch makes sure that nothing changes on OSX. | |||
| msg275504 -(view) | Author: Roundup Robot (python-dev) | Date: 2016-09-10 00:01 | |
New changeset3e02187e50df by Zachary Ware in branch 'default':Closes#27976: Deprecate bundled full copy of libffihttps://hg.python.org/cpython/rev/3e02187e50df | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:35 | admin | set | github: 72163 |
| 2016-09-10 00:01:35 | python-dev | set | status: open -> closed nosy: +python-dev messages: +msg275504 resolution: fixed stage: commit review -> resolved |
| 2016-09-08 00:04:56 | zach.ware | set | files: +issue27976.diff messages: +msg274926 |
| 2016-09-07 05:22:54 | yan12125 | set | messages: +msg274761 |
| 2016-09-06 21:06:26 | zach.ware | set | messages: +msg274628 |
| 2016-09-06 20:56:28 | berker.peksag | set | messages: +msg274627 stage: patch review -> commit review |
| 2016-09-06 18:54:54 | zach.ware | link | issue27979 dependencies |
| 2016-09-06 17:58:36 | zach.ware | link | issue23085 superseder |
| 2016-09-06 17:57:39 | zach.ware | set | components: + ctypes |
| 2016-09-06 17:56:22 | zach.ware | create | |