
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2016-06-22 21:04 byterry.reedy, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| locale-change.diff | terry.reedy,2016-06-22 21:04 | review | ||
| locale-change2.diff | terry.reedy,2016-06-26 21:43 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 1397 | merged | vstinner,2017-05-02 20:38 | |
| Messages (3) | |||
|---|---|---|---|
| msg269087 -(view) | Author: Terry J. Reedy (terry.reedy)*![]() | Date: 2016-06-22 21:04 | |
test.test_idle has long resulted in warnings about the locale being changed. In 3.6, this warning causes test_idle to be tagged a failure. Though this does not (yet) turn the overall run of a buildbot from green to red, it is annoying to have success reported as a failure.The culprit is in iomenu: locale.setlocale(locale.LC_CTYPE, "") Commenting it out removed the warning and tests pass. But I don't know the real effect, if it would work for tests on all systems, and the consequence when running IDLE normally.The problem cannot be monkey-patched away since the damage is done on import. Instead I added 'testing = False' to idlelib.__init__, made test_idle change it to True, and replace the locale-encoding code with "encoding = 'utf-8'" when testing is True.Serhiy, I *think* this is ready. However, another eagle-eye review would be welcome. Tests also pass with 'ascii'. Would that be better?---Side note: the locale and encoding code could use a review from someone who knows more that me. For instance, suppressing ImportError here: try: import locale locale.setlocale(locale.LC_CTYPE, "") except (ImportError, locale.Error): passguarantees a NameError a few lines further. There is another chunk labelled deprecated, and more might be obsolete in 3.x. But this is another issue. | |||
| msg269318 -(view) | Author: Terry J. Reedy (terry.reedy)*![]() | Date: 2016-06-26 21:47 | |
Added a couple of blank lines and expanded a comment. | |||
| msg269319 -(view) | Author: Roundup Robot (python-dev)![]() | Date: 2016-06-26 21:48 | |
New changeset3ffdb9277054 by Terry Jan Reedy in branch 'default':Issue 27372: Stop test_idle from changing locale, so test passes.https://hg.python.org/cpython/rev/3ffdb9277054 | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:32 | admin | set | github: 71559 |
| 2019-03-21 04:53:55 | terry.reedy | set | components: + IDLE |
| 2017-05-02 20:38:18 | vstinner | set | pull_requests: +pull_request1505 |
| 2016-06-26 21:49:20 | terry.reedy | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2016-06-26 21:48:18 | python-dev | set | nosy: +python-dev messages: +msg269319 |
| 2016-06-26 21:47:37 | terry.reedy | set | messages: +msg269318 |
| 2016-06-26 21:43:05 | terry.reedy | set | files: +locale-change2.diff |
| 2016-06-22 21:04:29 | terry.reedy | create | |