
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2015-09-14 10:13 bypitrou, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| traceback_extract_stack.patch | serhiy.storchaka,2015-09-14 17:29 | review | ||
| Messages (12) | |||
|---|---|---|---|
| msg250649 -(view) | Author: Antoine Pitrou (pitrou)*![]() | Date: 2015-09-14 10:13 | |
This can be considered a regression, although perhaps it may not be desirable to fix it in a later release.In 3.4:>>> def f(): return traceback.extract_stack()... >>> print([x[0:3] for x in f()])[('<stdin>', 1, '<module>'), ('<stdin>', 1, 'f')]In 3.5:>>> print([x[0:3] for x in f()])[('<stdin>', 1, '<module>'), ('<stdin>', 1, 'f'), ('/home/antoine/35/lib/python3.5/traceback.py', 201, 'extract_stack')]Note how the traceback module suddenly appears in the extracted stack. This breaks any application which uses a fixed offset into the returned stack to look up for information. | |||
| msg250650 -(view) | Author: Robert Collins (rbcollins)*![]() | Date: 2015-09-14 10:15 | |
Hmm, I think we can fix this. Its leaking due to the use of a helper I think. So - we should just fix this [and add a test, since clearly the test coverage is insufficient] | |||
| msg250651 -(view) | Author: Larry Hastings (larry)*![]() | Date: 2015-09-14 10:16 | |
Tracebacks aren't my forte, but this does smell like a regression and something that should be fixed.My worry about things like this is that it isn't as much a "bug" as a "badly implemented interface". As in, that's the interface in 3.5, and people will depend on it, and we change it in a point release at our peril. (That's why I didn't permit "fixing" warnings.warn(stacklevel=) for 3.4.) | |||
| msg250652 -(view) | Author: Antoine Pitrou (pitrou)*![]() | Date: 2015-09-14 10:21 | |
Note the doc says "Extract the raw traceback from the current stack frame". The "current stack frame" may be assumed to be the caller's (as it is in previous Python releases).Fortunately, this is also worked around by calling `extract_stack(sys._getframe())`. | |||
| msg250688 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)*![]() | Date: 2015-09-14 17:29 | |
Here is a patch that restores compatibility. There were no tests for print_stack(), format_stack(), and extract_stack() without arguments. New tests are passed with 3.4.There is a difference between this bug and warnings.warn(stacklevel=) at import time. In the latter the behavior is changed when we specify the stacklevel and we can't workaround this besides change the specified stacklevel depending on Python version. In the former the behavior is changed only when we don't specify a frame. The workaround is version independed: specify the frame explicitly. Therefore we will not break a code with a workaround for 3.5.0, but will fix a code without workaround. | |||
| msg250715 -(view) | Author: Alyssa Coghlan (ncoghlan)*![]() | Date: 2015-09-14 23:45 | |
Serhiy's explanation and fix look good to me. | |||
| msg250717 -(view) | Author: Robert Collins (rbcollins)*![]() | Date: 2015-09-15 00:37 | |
wouldn't changing walk_stack to add one more f_back be better? Seems odd to work around it... | |||
| msg250758 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)*![]() | Date: 2015-09-15 11:45 | |
> wouldn't changing walk_stack to add one more f_back be better?print_stack and format_stack need to add two more f_backs. | |||
| msg250947 -(view) | Author: Roundup Robot (python-dev)![]() | Date: 2015-09-18 07:10 | |
New changesetc9fb4362fb9f by Serhiy Storchaka in branch '3.5':Issue#25108: Omitted internal frames in traceback functions print_stack(),https://hg.python.org/cpython/rev/c9fb4362fb9fNew changeset4e617566bcb6 by Serhiy Storchaka in branch 'default':Issue#25108: Omitted internal frames in traceback functions print_stack(),https://hg.python.org/cpython/rev/4e617566bcb6New changeset9f57c937958f by Serhiy Storchaka in branch '3.4':Issue#25108: Backported tests for traceback functions print_stack(),https://hg.python.org/cpython/rev/9f57c937958fNew changesetf6125114b55f by Serhiy Storchaka in branch '2.7':Issue#25108: Backported tests for traceback functions print_stack(),https://hg.python.org/cpython/rev/f6125114b55f | |||
| msg251138 -(view) | Author: Arfrever Frehtes Taifersar Arahesis (Arfrever)*![]() | Date: 2015-09-20 05:10 | |
> New changesetf6125114b55f by Serhiy Storchaka in branch '2.7':> Issue#25108: Backported tests for traceback functions print_stack(),>https://hg.python.org/cpython/rev/f6125114b55fThe new tests fail on 2.7 branch whenLib/test/test_traceback.pyc is present, because __file__ can contain path to *.pyc files in Python 2.It is sufficient to run test_traceback twice to reproduce problem:$ LD_LIBRARY_PATH="$(pwd)" ./python -m test.regrtest -v test_traceback...$ LD_LIBRARY_PATH="$(pwd)" ./python -m test.regrtest -v test_traceback== CPython 2.7.10+ (2.7:fe84898fbe98, Sep 20 2015, 06:52:14) [GCC 4.9.3]== Linux-4.1.7 little-endian== /tmp/cpython/build/test_python_24845Testing with flags: sys.flags(debug=0, py3k_warning=0, division_warning=0, division_new=0, inspect=0, interactive=0, optimize=0, dont_write_bytecode=0, no_user_site=0, no_site=0, ignore_environment=0, tabcheck=0, verbose=0, unicode=0, bytes_warning=0, hash_randomization=0)[1/1] test_tracebacktest_bad_indentation (test.test_traceback.TracebackCases) ... oktest_base_exception (test.test_traceback.TracebackCases) ... oktest_bug737473 (test.test_traceback.TracebackCases) ... oktest_caret (test.test_traceback.TracebackCases) ... oktest_format_exception_only_bad__str__ (test.test_traceback.TracebackCases) ... oktest_nocaret (test.test_traceback.TracebackCases) ... oktest_string_exception1 (test.test_traceback.TracebackCases) ... oktest_string_exception2 (test.test_traceback.TracebackCases) ... oktest_unicode (test.test_traceback.TracebackCases) ... oktest_without_exception (test.test_traceback.TracebackCases) ... oktest_format_stack (test.test_traceback.TracebackFormatTests) ... FAILtest_print_stack (test.test_traceback.TracebackFormatTests) ... FAILtest_traceback_format (test.test_traceback.TracebackFormatTests) ... oktest_extract_stack (test.test_traceback.MiscTracebackCases) ... FAIL======================================================================FAIL: test_format_stack (test.test_traceback.TracebackFormatTests)----------------------------------------------------------------------Traceback (most recent call last): File "/tmp/cpython/Lib/test/test_traceback.py", line 232, in test_format_stack ' return traceback.format_stack()\n' % (__file__, lineno+1),AssertionError: Lists differ: [' File "/tmp/cpython/Lib/tes... != [' File "/tmp/cpython/Lib/tes...First differing element 0: File "/tmp/cpython/Lib/test/test_traceback.py", line 226, in test_format_stack result = fmt() File "/tmp/cpython/Lib/test/test_traceback.pyc", line 226, in test_format_stack result = fmt()- [' File "/tmp/cpython/Lib/test/test_traceback.py", line 226, in test_format_stack\n result = fmt()\n',+ [' File "/tmp/cpython/Lib/test/test_traceback.pyc", line 226, in test_format_stack\n result = fmt()\n',? +- ' File "/tmp/cpython/Lib/test/test_traceback.py", line 225, in fmt\n return traceback.format_stack()\n']+ ' File "/tmp/cpython/Lib/test/test_traceback.pyc", line 225, in fmt\n return traceback.format_stack()\n']? +======================================================================FAIL: test_print_stack (test.test_traceback.TracebackFormatTests)----------------------------------------------------------------------Traceback (most recent call last): File "/tmp/cpython/Lib/test/test_traceback.py", line 220, in test_print_stack ' traceback.print_stack()',AssertionError: Lists differ: [' File "/tmp/cpython/Lib/tes... != [' File "/tmp/cpython/Lib/tes...First differing element 0: File "/tmp/cpython/Lib/test/test_traceback.py", line 214, in test_print_stack File "/tmp/cpython/Lib/test/test_traceback.pyc", line 214, in test_print_stack- [' File "/tmp/cpython/Lib/test/test_traceback.py", line 214, in test_print_stack',+ [' File "/tmp/cpython/Lib/test/test_traceback.pyc", line 214, in test_print_stack',? + ' prn()',- ' File "/tmp/cpython/Lib/test/test_traceback.py", line 212, in prn',+ ' File "/tmp/cpython/Lib/test/test_traceback.pyc", line 212, in prn',? + ' traceback.print_stack()']======================================================================FAIL: test_extract_stack (test.test_traceback.MiscTracebackCases)----------------------------------------------------------------------Traceback (most recent call last): File "/tmp/cpython/Lib/test/test_traceback.py", line 248, in test_extract_stack (__file__, lineno+1, 'extract', 'return traceback.extract_stack()'),AssertionError: Lists differ: [('/tmp/cpython/Lib/test/test_... != [('/tmp/cpython/Lib/test/test_...First differing element 0:('/tmp/cpython/Lib/test/test_traceback.py', 244, 'test_extract_stack', 'result = extract()')('/tmp/cpython/Lib/test/test_traceback.pyc', 244, 'test_extract_stack', 'result = extract()')- [('/tmp/cpython/Lib/test/test_traceback.py',+ [('/tmp/cpython/Lib/test/test_traceback.pyc',? + 244, 'test_extract_stack', 'result = extract()'),- ('/tmp/cpython/Lib/test/test_traceback.py',+ ('/tmp/cpython/Lib/test/test_traceback.pyc',? + 243, 'extract', 'return traceback.extract_stack()')]----------------------------------------------------------------------Ran 14 tests in 4.029sFAILED (failures=3)test test_traceback failed -- multiple errors occurred1 test failed: test_traceback | |||
| msg251142 -(view) | Author: Roundup Robot (python-dev)![]() | Date: 2015-09-20 05:39 | |
New changeset7e718bbf5152 by Serhiy Storchaka in branch '2.7':Issue#25108: Fixed test_traceback in the case when this test is run twice.https://hg.python.org/cpython/rev/7e718bbf5152 | |||
| msg251143 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)*![]() | Date: 2015-09-20 05:40 | |
Thank you Arfrever. | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:21 | admin | set | github: 69295 |
| 2015-10-12 05:37:13 | berker.peksag | link | issue25379 superseder |
| 2015-09-20 05:40:52 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: resolved |
| 2015-09-20 05:40:19 | serhiy.storchaka | set | messages: +msg251143 |
| 2015-09-20 05:39:28 | python-dev | set | messages: +msg251142 |
| 2015-09-20 05:10:09 | Arfrever | set | status: closed -> open nosy: +Arfrever messages: +msg251138 resolution: fixed -> (no value) stage: resolved -> (no value) |
| 2015-09-18 07:11:14 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2015-09-18 07:10:21 | python-dev | set | nosy: +python-dev messages: +msg250947 |
| 2015-09-18 06:46:19 | serhiy.storchaka | set | assignee:serhiy.storchaka |
| 2015-09-15 11:45:53 | serhiy.storchaka | set | messages: +msg250758 |
| 2015-09-15 00:37:26 | rbcollins | set | messages: +msg250717 |
| 2015-09-14 23:45:20 | ncoghlan | set | messages: +msg250715 |
| 2015-09-14 17:29:07 | serhiy.storchaka | set | files: +traceback_extract_stack.patch nosy: +serhiy.storchaka messages: +msg250688 keywords: +patch stage: patch review |
| 2015-09-14 10:21:35 | pitrou | set | messages: +msg250652 |
| 2015-09-14 10:16:19 | larry | set | messages: +msg250651 |
| 2015-09-14 10:15:38 | rbcollins | set | messages: +msg250650 |
| 2015-09-14 10:13:43 | pitrou | create | |