➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2015-04-18 22:42 bychristian.heimes, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| import_reinit_fatal.patch | christian.heimes,2015-04-18 22:42 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg241462 -(view) | Author: Christian Heimes (christian.heimes)* | Date: 2015-04-18 22:42 | |
_PyImport_ReInitLock() doesn't check the return value of PyThread_allocate_lock(). A failed lock allocation can either lead to a NULL pointer dereference or to race conditions caused by a missing import lock.As there is no way to recover from a failed lock allication I recommend to abort with a fatal error.CID 1295025 (#1 of 1): Dereference after null check (FORWARD_NULL)var_deref_model: Passing null pointer import_lock to PyThread_acquire_lock, which dereferences it. | |||
| msg241517 -(view) | Author: Brett Cannon (brett.cannon)* | Date: 2015-04-19 14:18 | |
LGTM | |||
| msg241547 -(view) | Author: Roundup Robot (python-dev) | Date: 2015-04-19 19:15 | |
New changesetd70995cf44b3 by Christian Heimes in branch '2.7':Issue#23998: PyImport_ReInitLock() now checks for lock allocation errorhttps://hg.python.org/cpython/rev/d70995cf44b3New changeset7d7bf5c34d7e by Christian Heimes in branch '3.3':Issue#23998: PyImport_ReInitLock() now checks for lock allocation errorhttps://hg.python.org/cpython/rev/7d7bf5c34d7eNew changesete0bd083fc9c1 by Christian Heimes in branch '3.4':Issue#23998: PyImport_ReInitLock() now checks for lock allocation errorhttps://hg.python.org/cpython/rev/e0bd083fc9c1New changeset7ae8fd62d743 by Christian Heimes in branch 'default':Issue#23998: PyImport_ReInitLock() now checks for lock allocation errorhttps://hg.python.org/cpython/rev/7ae8fd62d743 | |||
| msg241656 -(view) | Author: Christian Heimes (christian.heimes)* | Date: 2015-04-20 14:52 | |
Thanks, Brett! | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:15 | admin | set | github: 68186 |
| 2015-04-20 14:52:14 | christian.heimes | set | status: open -> closed resolution: fixed messages: +msg241656 stage: commit review -> resolved |
| 2015-04-19 19:15:52 | python-dev | set | nosy: +python-dev messages: +msg241547 |
| 2015-04-19 14:18:02 | brett.cannon | set | nosy: +brett.cannon messages: +msg241517 assignee:christian.heimes stage: patch review -> commit review |
| 2015-04-18 22:42:35 | christian.heimes | create | |