Movatterモバイル変換


[0]ホーム

URL:


homepage

Issue23977

This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title:Enhancing IDLE's test_delegator.py unit test
Type:enhancementStage:resolved
Components:TestsVersions:Python 3.6, Python 3.5
process
Status:closedResolution:fixed
Dependencies:Superseder:
Assigned To: terry.reedyNosy List: Al.Sweigart, python-dev, terry.reedy
Priority:normalKeywords:patch

Created on2015-04-16 22:18 byAl.Sweigart, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.

Files
File nameUploadedDescriptionEdit
test_delegator.patchAl.Sweigart,2015-04-16 22:18review
Messages (3)
msg241284 -(view)Author: Al Sweigart (Al.Sweigart)*Date: 2015-04-16 22:18
As part of trying to understand the IDLE codebase, I'm taking a look at IDLE's unit tests.-Added more specific messages when test_delegator.py's assertions fail.-Added detail to the comments.-Added an explicit test of the resetcache() method (which before was only tested as far as it was called when setdelegate() was called).I've rerun the unit test on the existing source code and it passes.
msg265584 -(view)Author: Terry J. Reedy (terry.reedy)*(Python committer)Date: 2016-05-15 05:56
The patch adds too much.  Some of the comments are too obvious.  SeePEP 8.  Many of the messages repeat the information already provided in the custom messages already provided by the assertXyz failure methods.  For instance, when assertEqual(a, b) fails, the message already prints out something like "%s != $s" % (repr(a), repr(b)).  Perhaps you were not familiar with this.  One of the problems of retrofitting tests is that we do not see the default failure messages.In any case, over-commenting and over-messaging are not harmless as they make code and failure messages harder, not easier to read.  I will review and add what I think is useful.
msg265659 -(view)Author: Roundup Robot (python-dev)(Python triager)Date: 2016-05-16 02:07
New changeset6bc08af57813 by Terry Jan Reedy in branch '3.5':Issue#23977: Tweak IDLE Delegator and its test.https://hg.python.org/cpython/rev/6bc08af57813
History
DateUserActionArgs
2022-04-11 14:58:15adminsetgithub: 68165
2016-05-16 02:08:11terry.reedysetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2016-05-16 02:07:42python-devsetnosy: +python-dev
messages: +msg265659
2016-05-15 05:56:51terry.reedysetversions: + Python 3.6
nosy: +terry.reedy

messages: +msg265584

assignee:terry.reedy
stage: patch review
2015-04-16 22:18:37Al.Sweigartcreate
Supported byThe Python Software Foundation,
Powered byRoundup
Copyright © 1990-2022,Python Software Foundation
Legal Statements

[8]ページ先頭

©2009-2026 Movatter.jp