Topic previously discussed at:https://mail.python.org/pipermail/python-dev/2013-May/126285.htmlRelated issue:http://bugs.python.org/issue12082Antoine Pitrou wrote in the issue:"I would personally like to remove HAVE_FSTAT and make Python unconditionally use fstat(). It will make the code quite simpler in some places."I agree. I'm quite sure that Python doesn't work on such platform, and it would require much more changes than just making fstat optional.So I'm in favor of dropping the check on fstat() and expect it to be always available.Examples of Python modules of the standard library using os.fstat:- fileinput- genericpath- netrc- os which contains "set.add(stat) # fstat always works"- _pyio (the call is optional, it catchs AttributeError)- shutil- socket- tarfile- asyncio- http.client (optional, catch AttributeError)- http.server- logging- io- etc.

stat.patch: Stop pretending that Python works without stat() nor fstat(), consider that these functions are always available.

Seeissue22623 for moving in opposite direction.

My changes only *removes* code and so make it simpler ;-)$ diffstat stat.patchInclude/fileutils.h  |    6 ------Include/pyport.h     |   22 ----------------------Modules/_io/fileio.c |   20 --------------------Modules/mmapmodule.c |    4 ----Python/fileutils.c   |   16 ----------------Python/marshal.c     |    4 ---- 6 files changed, 72 deletions(-)

+1 from me, fstat() has always been par of POSIX.It's really likely Python won't build anyway on such systems.

See alsoissue12082.

> Serhiy Storchaka added the comment:>> See alsoissue12082.Yes, but I don't think we want to clutter the code to support exoticniche platforms.

Antoine and Charles-François are in favor of removing these #ifdef.Serhiy wrote:> Seeissue22623 for moving in opposite direction.Not exactly, Link Mauve wrote "On those two platforms, fstat() is correctly defined and works fine, so it shouldn’t be a problem to drop its #ifdef."

New changeseta84eae63b4cd by Victor Stinner in branch 'default':Issue#23753: Python doesn't support anymore platforms without stat() orhttps://hg.python.org/cpython/rev/a84eae63b4cd

> -#if defined(HAVE_STAT) && !defined(MS_WINDOWS)This doesn't look correct. An equivalent replacement is -#if defined(HAVE_STAT) && !defined(MS_WINDOWS)+#if !defined(MS_WINDOWS)

New changesetad5521dd7b80 by Victor Stinner in branch 'default':Issue#23753: Move _Py_wstat() fromPython/fileutils.c toModules/getpath.chttps://hg.python.org/cpython/rev/ad5521dd7b80

> -#if defined(HAVE_STAT) && !defined(MS_WINDOWS)> This doesn't look correct. An equivalent replacement is Oh, I missed the "!". Only _Py_wstat() uses this test. Windows has _wstat(), so _Py_wstat() could use it.I added deliberately "!defined(MS_WINDOWS)" because _Py_wstat() is only used inModules/getpath.c and this file is not compiled on Windows.Instead of modifying _Py_wstat(), I moved it back toModules/getpath.c. There is no need to overengineer this function only called 3 times in getpath.c.