➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2015-03-06 00:54 byAntony.Lee, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| gzip-argparse-cli.patch | Antony.Lee,2015-03-06 00:54 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 9775 | merged | matrixise,2018-10-09 16:10 | |
| PR 9779 | merged | miss-islington,2018-10-09 21:17 | |
| PR 9780 | merged | miss-islington,2018-10-09 21:17 | |
| PR 9781 | merged | matrixise,2018-10-09 21:46 | |
| Messages (10) | |||
|---|---|---|---|
| msg237315 -(view) | Author: Antony Lee (Antony.Lee)* | Date: 2015-03-06 00:54 | |
The attached patch reimplements gzip's already existing command-line interface using argparse, both to provide command-line help and to avoid manual argument parsing. | |||
| msg237322 -(view) | Author: Berker Peksag (berker.peksag)* | Date: 2015-03-06 02:22 | |
Thanks for the patch, but we need to add tests for the current CLI to make sure that we don't break anything when we apply gzip-argparse-cli.patch. SeeLib/test/test_tarfile.py andLib/test/test_calendar.py for example CLI tests. | |||
| msg327426 -(view) | Author: Stéphane Wirtel (matrixise)* | Date: 2018-10-09 16:14 | |
Hi Berker,Here is my PR for this issue.From this PR, I will add the new CLI with argparse.And after this issue, I will work onhttps://bugs.python.org/issue34913 | |||
| msg327432 -(view) | Author: Karthikeyan Singaravelan (xtreak)* | Date: 2018-10-09 19:23 | |
Thanks @matrixise for the PR. This seems to be a good first step for both testing the command line interface and also argparse can generate help string which can be used forissue34913. | |||
| msg327437 -(view) | Author: Julien Palard (mdk)* | Date: 2018-10-09 21:16 | |
New changeset84eec1199583bcb034e43337bcb8e2b876ebd269 by Julien Palard (Stéphane Wirtel) in branch 'master':bpo-23596: Add unit tests for the command line for the gzip module (GH-9775)https://github.com/python/cpython/commit/84eec1199583bcb034e43337bcb8e2b876ebd269 | |||
| msg327438 -(view) | Author: Stéphane Wirtel (matrixise)* | Date: 2018-10-09 21:22 | |
And now, I am going to work on the refactoring with argparse | |||
| msg327439 -(view) | Author: miss-islington (miss-islington) | Date: 2018-10-09 21:42 | |
New changeset482dc9445d834f1d03c501b45fafd422b6eb8c9c by Miss Islington (bot) in branch '3.6':bpo-23596: Add unit tests for the command line for the gzip module (GH-9775)https://github.com/python/cpython/commit/482dc9445d834f1d03c501b45fafd422b6eb8c9c | |||
| msg327440 -(view) | Author: miss-islington (miss-islington) | Date: 2018-10-09 21:43 | |
New changeset8e23ba021f45df67edd2926a3e3daf6a2a1f0ed8 by Miss Islington (bot) in branch '3.7':bpo-23596: Add unit tests for the command line for the gzip module (GH-9775)https://github.com/python/cpython/commit/8e23ba021f45df67edd2926a3e3daf6a2a1f0ed8 | |||
| msg327442 -(view) | Author: Julien Palard (mdk)* | Date: 2018-10-09 22:41 | |
New changesete8bbc52debfd1b28517946d65db257e6b6d92e29 by Julien Palard (Stéphane Wirtel) in branch 'master':bpo-23596: Use argparse for the command line of gzip (GH-9781)https://github.com/python/cpython/commit/e8bbc52debfd1b28517946d65db257e6b6d92e29 | |||
| msg327443 -(view) | Author: Stéphane Wirtel (matrixise)* | Date: 2018-10-09 22:45 | |
I have added some tests for 3.6, 3.7 and 3.8.But for the new CLI, just for 3.8now, I am going to close this issue. | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:13 | admin | set | github: 67784 |
| 2018-10-10 06:49:12 | mdk | set | resolution: fixed |
| 2018-10-09 22:45:13 | matrixise | set | status: open -> closed stage: patch review -> resolved messages: +msg327443 versions: + Python 3.6, Python 3.7, Python 3.8, - Python 3.5 |
| 2018-10-09 22:41:43 | mdk | set | messages: +msg327442 |
| 2018-10-09 21:46:14 | matrixise | set | pull_requests: +pull_request9167 |
| 2018-10-09 21:43:02 | miss-islington | set | messages: +msg327440 |
| 2018-10-09 21:42:31 | miss-islington | set | nosy: +miss-islington messages: +msg327439 |
| 2018-10-09 21:22:25 | matrixise | set | messages: +msg327438 |
| 2018-10-09 21:17:18 | miss-islington | set | pull_requests: +pull_request9166 |
| 2018-10-09 21:17:09 | miss-islington | set | pull_requests: +pull_request9165 |
| 2018-10-09 21:16:48 | mdk | set | nosy: +mdk messages: +msg327437 |
| 2018-10-09 20:02:15 | Antony.Lee | set | nosy: -Antony.Lee |
| 2018-10-09 19:23:37 | xtreak | set | nosy: +xtreak messages: +msg327432 |
| 2018-10-09 16:14:13 | matrixise | set | nosy: +matrixise messages: +msg327426 |
| 2018-10-09 16:10:38 | matrixise | set | pull_requests: +pull_request9162 |
| 2015-03-06 02:22:24 | berker.peksag | set | nosy: +berker.peksag messages: +msg237322 type: enhancement stage: patch review |
| 2015-03-06 00:54:31 | Antony.Lee | create | |