➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2014-06-11 15:13 bymdengler, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| cpython-patch-Lib-distutils-command-upload.py.patch | mdengler,2014-06-11 23:24 | review | ||
| cpython2-patch-Lib-distutils-command-upload.py.patch | mdengler,2014-06-11 23:24 | review | ||
| cpython-patch-Lib-distutils-command-upload.py.patch | mdengler,2014-06-12 00:38 | review | ||
| cpython2-patch-Lib-distutils-command-upload.py.patch | mdengler,2014-06-12 00:39 | review | ||
| Messages (14) | |||
|---|---|---|---|
| msg220276 -(view) | Author: Martin Dengler (mdengler)* | Date: 2014-06-11 15:13 | |
This patch teaches distutils/command/upload.py to return a non-zero exit code when uploading fails. Currently a zero error code is returned (specifically, no Exception is raised by upload.run(...)) regardless of the HTTP response from the server or any socket error during that conversation.Should be applied against tip.Thanks. | |||
| msg220277 -(view) | Author: Martin Dengler (mdengler)* | Date: 2014-06-11 15:13 | |
The attached file is a patch for backporting this fix to 2.7.7. | |||
| msg220314 -(view) | Author: Antoine Pitrou (pitrou)* | Date: 2014-06-11 22:18 | |
Thanks you for the patch. It may be good to add a unit test for this.Also, for development, it is probably better to use a Mercurial clone instead of trying to generate diffs by hand. See thedevguide for more information:https://docs.python.org/devguide/ | |||
| msg220320 -(view) | Author: Martin Dengler (mdengler)* | Date: 2014-06-11 23:24 | |
Here is the patch against hg tip. | |||
| msg220321 -(view) | Author: Martin Dengler (mdengler)* | Date: 2014-06-11 23:24 | |
Here is the patch against hg 2.7. | |||
| msg220322 -(view) | Author: Martin Dengler (mdengler)* | Date: 2014-06-11 23:26 | |
I will submit patches with tests as soon as the before & after tests finish. | |||
| msg220323 -(view) | Author: Martin Dengler (mdengler)* | Date: 2014-06-12 00:38 | |
Here is the patch against tip, including a new test case. | |||
| msg220324 -(view) | Author: Martin Dengler (mdengler)* | Date: 2014-06-12 00:39 | |
Here is the patch against 2.7, including a new test case. | |||
| msg220325 -(view) | Author: Martin Dengler (mdengler)* | Date: 2014-06-12 00:39 | |
If you'd like me to change anything about the test case please let me know. | |||
| msg220909 -(view) | Author: Martin Dengler (mdengler)* | Date: 2014-06-17 22:42 | |
I've got the contrib form bit now. | |||
| msg220946 -(view) | Author: Antoine Pitrou (pitrou)* | Date: 2014-06-18 18:07 | |
Thank you Martin. I will take a look soon at the patch. | |||
| msg220957 -(view) | Author: Roundup Robot (python-dev) | Date: 2014-06-19 03:09 | |
New changesetd86214c98a9c by Antoine Pitrou in branch '3.4':Issue#21722: The distutils "upload" command now exits with a non-zero return code when uploading fails.http://hg.python.org/cpython/rev/d86214c98a9cNew changeset979aaa08c067 by Antoine Pitrou in branch 'default':Issue#21722: The distutils "upload" command now exits with a non-zero return code when uploading fails.http://hg.python.org/cpython/rev/979aaa08c067 | |||
| msg220958 -(view) | Author: Roundup Robot (python-dev) | Date: 2014-06-19 03:15 | |
New changesetcf70f030a744 by Antoine Pitrou in branch '2.7':Issue#21722: The distutils "upload" command now exits with a non-zero return code when uploading fails.http://hg.python.org/cpython/rev/cf70f030a744 | |||
| msg220959 -(view) | Author: Antoine Pitrou (pitrou)* | Date: 2014-06-19 03:15 | |
I've now committed the fix. Thank you for your contribution! | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:04 | admin | set | github: 65921 |
| 2014-06-19 03:15:56 | pitrou | set | status: open -> closed versions: + Python 3.4 type: behavior messages: +msg220959 resolution: fixed stage: resolved |
| 2014-06-19 03:15:06 | python-dev | set | messages: +msg220958 |
| 2014-06-19 03:09:26 | python-dev | set | nosy: +python-dev messages: +msg220957 |
| 2014-06-18 18:07:15 | pitrou | set | messages: +msg220946 |
| 2014-06-17 22:42:24 | mdengler | set | messages: +msg220909 |
| 2014-06-12 00:39:59 | mdengler | set | messages: +msg220325 |
| 2014-06-12 00:39:09 | mdengler | set | files: +cpython2-patch-Lib-distutils-command-upload.py.patch messages: +msg220324 |
| 2014-06-12 00:38:44 | mdengler | set | files: +cpython-patch-Lib-distutils-command-upload.py.patch messages: +msg220323 |
| 2014-06-11 23:26:56 | mdengler | set | messages: +msg220322 |
| 2014-06-11 23:25:14 | mdengler | set | files: -cpython2-patch-Lib-distutils-command-upload.py.patch |
| 2014-06-11 23:25:07 | mdengler | set | files: -cpython-patch-Lib-distutils-command-upload.py.patch |
| 2014-06-11 23:24:53 | mdengler | set | files: +cpython2-patch-Lib-distutils-command-upload.py.patch messages: +msg220321 |
| 2014-06-11 23:24:30 | mdengler | set | files: +cpython-patch-Lib-distutils-command-upload.py.patch messages: +msg220320 |
| 2014-06-11 22:18:59 | pitrou | set | nosy: +pitrou messages: +msg220314 |
| 2014-06-11 20:17:02 | ned.deily | set | nosy: +eric.araujo,dstufft components: + Distutils |
| 2014-06-11 15:13:53 | mdengler | set | files: +cpython2-patch-Lib-distutils-command-upload.py.patch messages: +msg220277 |
| 2014-06-11 15:13:10 | mdengler | create | |