
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2014-03-15 19:41 byned.deily, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue20939_all_27.patch | ned.deily,2014-03-17 09:49 | 2.7 | ||
| issue20939_all_31.patch | ned.deily,2014-03-17 09:49 | 3.1 | ||
| issue20939_all_32.patch | ned.deily,2014-03-17 09:49 | 3.2 | ||
| issue20939_all_33.patch | ned.deily,2014-03-17 09:50 | 3.3 | ||
| issue20939_all_3x.patch | ned.deily,2014-03-17 09:50 | 3.4 and default | review | |
| Messages (11) | |||
|---|---|---|---|
| msg213677 -(view) | Author: Ned Deily (ned.deily)*![]() | Date: 2014-03-15 19:41 | |
It looks like another change to the new python.org website is breaking another test:======================================================================FAIL: test_geturl (test.test_urllibnet.urlopenNetworkTests)----------------------------------------------------------------------Traceback (most recent call last): File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/test/test_urllibnet.py", line 86, in test_geturl self.assertEqual(gotten_url, URL)AssertionError: 'https://www.python.org/' != 'http://www.python.org/'-https://www.python.org/? -+http://www.python.org/ | |||
| msg213679 -(view) | Author: Roundup Robot (python-dev)![]() | Date: 2014-03-15 20:19 | |
New changeset9b02f23bc129 by Ned Deily in branch '2.7':Issue#20939: Fix test_geturl failure in test_urllibnet due tohttp://hg.python.org/cpython/rev/9b02f23bc129New changeset030efedd70ca by Ned Deily in branch '3.3':Issue#20939: Fix test_geturl failure in test_urllibnet due tohttp://hg.python.org/cpython/rev/030efedd70caNew changeset9358a41b245b by Ned Deily in branch 'default':Issue#20939: merge from 3.3http://hg.python.org/cpython/rev/9358a41b245b | |||
| msg213680 -(view) | Author: Ned Deily (ned.deily)*![]() | Date: 2014-03-15 20:22 | |
The above changes temporarily fix the problem as long as the build include ssl support. We should probably change all of the tests to use some other domain that does not redirect to https:www.example.com has been suggested. | |||
| msg213795 -(view) | Author: Roundup Robot (python-dev)![]() | Date: 2014-03-17 06:30 | |
New changeset7f4fba171a40 by Ned Deily in branch '3.4':Issue#20939: merge from 3.3http://hg.python.org/cpython/rev/7f4fba171a40 | |||
| msg213846 -(view) | Author: Ned Deily (ned.deily)*![]() | Date: 2014-03-17 09:49 | |
Here are patches to change network use ofwww.python.org towww.example.com so that the tests should pass even if the interpreter is built without SSL support. It turns out that there are references towww.python.org in unexpected places (like test_site) so, while I ran all tests and tested the changes both with and without SSL availability, it wouldn't surprise me if I missed a few spots. Also, as requested by Benjamin, I produced patches for and tested on 3.1 and 3.2. I'm +0 on applying the changes there as there are other, unrelated test failures with those releases on some platforms, but with the patches no one can blame the new python.org website for them. | |||
| msg214177 -(view) | Author: Senthil Kumaran (orsenthil)*![]() | Date: 2014-03-20 06:13 | |
The suggested patch(s) looks good to me. | |||
| msg214937 -(view) | Author: Roundup Robot (python-dev)![]() | Date: 2014-03-27 06:34 | |
New changeset426a7046cdb0 by Ned Deily in branch '2.7':Issue#20939: Usewww.example.com instead ofwww.python.org to avoid testhttp://hg.python.org/cpython/rev/426a7046cdb0New changeset31e42208eb99 by Ned Deily in branch '3.4':Issue#20939: Backout test_urllib2.test_issue16464 disables:http://hg.python.org/cpython/rev/31e42208eb99New changeset6134684ba222 by Ned Deily in branch '3.4':Issue#20939: Usewww.example.com instead ofwww.python.org to avoid testhttp://hg.python.org/cpython/rev/6134684ba222New changeset67dcb2d19dc4 by Ned Deily in branch 'default':Issue#20939: merge from 3.4http://hg.python.org/cpython/rev/67dcb2d19dc4 | |||
| msg214938 -(view) | Author: Roundup Robot (python-dev)![]() | Date: 2014-03-27 06:44 | |
New changesetb533cc11d114 by Ned Deily in branch '3.4':Issue#20939: remove stray character from commenthttp://hg.python.org/cpython/rev/b533cc11d114New changesetff27cb871b16 by Ned Deily in branch 'default':Issue#20939: merge from 3.4http://hg.python.org/cpython/rev/ff27cb871b16 | |||
| msg214946 -(view) | Author: Ned Deily (ned.deily)*![]() | Date: 2014-03-27 09:24 | |
I've pushed the changes to 2.7, 3.4, and default. That has exposed a new intermittent failure of test_fileno in test.test_urllibnet (seeIssue21069). I'll leave this issue open until that is resolved. And I'll leave it up to the respective release managers to decide whether they want to backport to their security-fix-only branches. | |||
| msg221331 -(view) | Author: Ned Deily (ned.deily)*![]() | Date: 2014-06-23 00:55 | |
Since the original problems reported here have been fixed in current branches, I'm closing this issue. | |||
| msg227930 -(view) | Author: Roundup Robot (python-dev)![]() | Date: 2014-09-30 14:22 | |
New changeset97c329849ef3 by Ned Deily in branch '3.2':Issue#20939: Usewww.example.com instead ofwww.python.org to avoid testhttps://hg.python.org/cpython/rev/97c329849ef3 | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:00 | admin | set | github: 65138 |
| 2014-09-30 14:22:56 | python-dev | set | messages: +msg227930 |
| 2014-06-23 00:55:16 | ned.deily | set | status: open -> closed versions: - Python 3.1, Python 3.2, Python 3.3 messages: +msg221331 resolution: fixed stage: commit review -> resolved |
| 2014-04-15 19:26:56 | ddvento@ucar.edu | set | nosy: +ddvento@ucar.edu |
| 2014-03-27 09:24:22 | ned.deily | set | messages: +msg214946 stage: patch review -> commit review |
| 2014-03-27 06:44:49 | python-dev | set | messages: +msg214938 |
| 2014-03-27 06:34:27 | python-dev | set | messages: +msg214937 |
| 2014-03-20 18:45:34 | Arfrever | set | nosy: +Arfrever |
| 2014-03-20 06:13:02 | orsenthil | set | nosy: +orsenthil messages: +msg214177 |
| 2014-03-19 17:42:18 | ned.deily | link | issue20982 superseder |
| 2014-03-17 09:50:31 | ned.deily | set | files: +issue20939_all_3x.patch |
| 2014-03-17 09:50:01 | ned.deily | set | files: +issue20939_all_33.patch |
| 2014-03-17 09:49:38 | ned.deily | set | files: +issue20939_all_32.patch |
| 2014-03-17 09:49:22 | ned.deily | set | files: +issue20939_all_31.patch |
| 2014-03-17 09:49:03 | ned.deily | set | files: +issue20939_all_27.patch assignee:ned.deily versions: + Python 3.1, Python 3.2, Python 3.5 keywords: +patch nosy: +georg.brandl,benjamin.peterson messages: +msg213846 stage: needs patch -> patch review |
| 2014-03-17 06:30:41 | python-dev | set | messages: +msg213795 |
| 2014-03-16 23:21:25 | GreenKey | set | nosy: +GreenKey |
| 2014-03-15 20:22:39 | ned.deily | set | messages: +msg213680 |
| 2014-03-15 20:19:53 | python-dev | set | nosy: +python-dev messages: +msg213679 |
| 2014-03-15 19:41:17 | ned.deily | create | |