The docs on file's constructor says that the 'U' mode should not workwith '+', and yet 'rU+' does not throw an error.

Attaching a patch that checks for '+' in the mode string, updates the docs, and tests bad mode strings.

I can confirm that:- the patch applies cleanly to the release26-maint branch, with the  exception of theMisc/NEWS portion::  $ hg branch  release26-maint  $ ./python -E -ttLib/test/regrtest.py test_file  test_file  1 test OK.  $ patch -p0 < /tmp/issue2091.diff   patching fileObjects/fileobject.c  Hunk #1 succeeded at 209 (offset 54 lines).  Hunk #2 succeeded at 2269 (offset 194 lines).  patching fileMisc/NEWS  Hunk #1 FAILED at 12.  1 out of 1 hunk FAILED -- saving rejects to fileMisc/NEWS.rej  patching fileLib/test/test_file.py  Hunk #1 succeeded at 176 (offset 55 lines).- the added test fails before rebuildingObjects/fileobject.c::  $ ./python -E -ttLib/test/regrtest.py test_file  test_file  test test_file failed -- Traceback (most recent call last):    File "/home/tseaver/projects/hg-repo/py-2.6/Lib/test/test_file.py", line 181, in testModeStrings      f = open(TESTFN, mode)  IOError: [Errno 2] No such file or directory: '@test'    1 test failed:      test_file- the added test passes after rebuildingObjects/fielobject.c::  $ make  gcc -pthread -c -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes  -I. -IInclude -I./Include   -DPy_BUILD_CORE -oObjects/fileobject.oObjects/fileobject.c  ...  $ ./python -E -ttLib/test/regrtest.py test_file  test_file  1 test OK.

The patch is now way out of date to the extent that I can't find the code in fileobject.c, perhaps I'm just blind  Can someone please provide a new patch, thanks.

Of course, the implementation is now in the io module:Modules/_io/_iomodule.c *and*Lib/_pyio.py

In Python 3, the documentation no longer mentions that 'U' should not work with '+' (or 'w' or 'a', for that matter), and the code throws ValueError if 'U' is used with 'w' or 'a', but not '+'.On the other hand, the documentation *does* mention that 'U' is for backwards compatibility and shouldn't be used with new code.In light of this, how do you suggest to proceed with this issue?

It seems to me that adding the proper check is a good idea. It also may not be obvious to some that 'U' is now more or less an alias for 'r'. I have updated the patch so that it at least applies.I also removed a redundant `reading = 1`

> On the other hand, the documentation *does* mention that> 'U' is for backwards compatibility and shouldn't be used> with new code.Shouldn't be some deprecation warning somewhere?

In Python 3.4+ 'U' already emits deprecation warning.

Updated patch. I'm not going to apply right now - giving it a little time to let folk chime on whether this should be applied all the way back to 3.4, or not.My inclination is to only apply it to 3.6.

I agree, a change that emits an error where none was emitted before should only go in the next release.  With a what's new entry.It is possible there should be a deprecation or -3 warning in 2.7, but I'm not sure it is worth the effort.

@Larry - should this go in 3.5, or would you rather it not?

I would add a warning in 3.4- (or 3.5-). The 'U' mode should not workwith '+', and it can't work with '+' correctly. This is a bug that we can decide not fix by raising an exception.

Yeah, considering how long this bug has been sitting around, I think we can wait for one more release for the fix.  3.6 please.

New changeset1a5bbb31f740 by Robert Collins in branch 'default':- Issue#2091: error correctly on open() with mode 'U' and '+'https://hg.python.org/cpython/rev/1a5bbb31f740

@larry thanks - that was my inclination too. Applied to 3.6@Serhiy I've not done a warning in 3.4/3.5 because - the behaviour is already broken, this patch just catches it a lot earlier (on open rather than subsequent operations).

Perhaps the 'U' mode should just raise an exception in 3.6.

New changeset21a9ba1992775b5a833da28bfa0a9f028d1b6761 by Berker Peksag in branch 'master':bpo-2091: Fix typo in exception message (GH-12987)https://github.com/python/cpython/commit/21a9ba1992775b5a833da28bfa0a9f028d1b6761

New changesetf5972cc0c9a8e3315207e2d67534f330d619af4e by Berker Peksag (Miss Islington (bot)) in branch '3.7':bpo-2091: Fix typo in exception message (GH-12987)https://github.com/python/cpython/commit/f5972cc0c9a8e3315207e2d67534f330d619af4e