Movatterモバイル変換


[0]ホーム

URL:


homepage

Issue20289

This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title:Make cgi.FieldStorage a context manager
Type:enhancementStage:resolved
Components:Library (Lib)Versions:Python 3.5
process
Status:closedResolution:fixed
Dependencies:Superseder:
Assigned To:Nosy List: berker.peksag, brett.cannon, python-dev, serhiy.storchaka
Priority:normalKeywords:patch

Created on2014-01-17 14:47 bybrett.cannon, last changed2022-04-11 14:57 byadmin. This issue is nowclosed.

Files
File nameUploadedDescriptionEdit
issue20289.diffberker.peksag,2014-01-20 20:38review
issue20289_v2.diffberker.peksag,2015-02-05 06:21review
Messages (10)
msg208338 -(view)Author: Brett Cannon (brett.cannon)*(Python committer)Date: 2014-01-17 14:47
It has a file attribute which contains a file, so making it so it can be closed faster than cgi.FieldStorage.__del__ would be good.
msg208579 -(view)Author: Berker Peksag (berker.peksag)*(Python committer)Date: 2014-01-20 20:38
Here's a patch with a test and documentation update.
msg230737 -(view)Author: Serhiy Storchaka (serhiy.storchaka)*(Python committer)Date: 2014-11-06 13:01
Added comments on Rietveld.
msg235405 -(view)Author: Serhiy Storchaka (serhiy.storchaka)*(Python committer)Date: 2015-02-04 21:22
Ping.
msg235418 -(view)Author: Berker Peksag (berker.peksag)*(Python committer)Date: 2015-02-05 06:21
Here's an updated patch. Thank you Serhiy.
msg235437 -(view)Author: Serhiy Storchaka (serhiy.storchaka)*(Python committer)Date: 2015-02-05 13:29
LGTM.
msg235470 -(view)Author: Berker Peksag (berker.peksag)*(Python committer)Date: 2015-02-06 08:22
Thanks for the review, Serhiy!
msg235471 -(view)Author: Roundup Robot (python-dev)(Python triager)Date: 2015-02-06 08:22
New changeset367f5e98ffbb by Berker Peksag in branch 'default':Issue#20289: cgi.FieldStorage() now supports the context management protocol.https://hg.python.org/cpython/rev/367f5e98ffbb
msg239147 -(view)Author: Roundup Robot (python-dev)(Python triager)Date: 2015-03-24 16:07
New changeset34930a6faf0d by Serhiy Storchaka in branch 'default':Issue#20289: The copy module now uses pickle protocol 4 (PEP 3154) andhttps://hg.python.org/cpython/rev/34930a6faf0d
msg252808 -(view)Author: Roundup Robot (python-dev)(Python triager)Date: 2015-10-11 14:55
New changeset80501740ab84 by Serhiy Storchaka in branch '3.5':No longer skip tests for classes with __getnewargs_ex__.  The copy modulehttps://hg.python.org/cpython/rev/80501740ab84New changeset6f4dd9bc1f20 by Serhiy Storchaka in branch 'default':No longer skip tests for classes with __getnewargs_ex__.  The copy modulehttps://hg.python.org/cpython/rev/6f4dd9bc1f20
History
DateUserActionArgs
2022-04-11 14:57:57adminsetgithub: 64488
2015-10-11 14:55:15python-devsetmessages: +msg252808
2015-03-24 16:07:25python-devsetmessages: +msg239147
2015-02-06 08:22:22python-devsetnosy: +python-dev
messages: +msg235471
2015-02-06 08:22:03berker.peksagsetstatus: open -> closed
resolution: fixed
messages: +msg235470

stage: commit review -> resolved
2015-02-05 13:29:32serhiy.storchakasetmessages: +msg235437
stage: patch review -> commit review
2015-02-05 06:21:25berker.peksagsetfiles: +issue20289_v2.diff

messages: +msg235418
2015-02-04 21:22:13serhiy.storchakasetmessages: +msg235405
2014-11-06 13:01:18serhiy.storchakasettype: behavior -> enhancement

messages: +msg230737
nosy: +serhiy.storchaka
2014-01-20 20:38:50berker.peksagsetfiles: +issue20289.diff
keywords: +patch
2014-01-20 20:38:34berker.peksagsetnosy: +berker.peksag

messages: +msg208579
stage: test needed -> patch review
2014-01-17 14:47:25brett.cannoncreate
Supported byThe Python Software Foundation,
Powered byRoundup
Copyright © 1990-2022,Python Software Foundation
Legal Statements

[8]ページ先頭

©2009-2026 Movatter.jp