➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2013-03-31 19:52 byrpetrov, last changed2022-04-11 14:57 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 0007-MINGW-add-wincrypt.h-in-Python-random.c.patch | rpetrov,2013-03-31 19:52 | |||
| 0006-MINGW-add-wincrypt.h-in-Python-random.c.patch | rpetrov,2014-08-03 06:11 | status on 2014-08-02 | ||
| MINGW-wincrypt.v3.patch | martin.panter,2016-03-10 10:02 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg185656 -(view) | Author: Roumen Petrov (rpetrov)* | Date: 2013-03-31 19:52 | |
split ofissue3871 | |||
| msg185672 -(view) | Author: Antoine Pitrou (pitrou)* | Date: 2013-03-31 20:54 | |
Why the "#ifdef __MINGW32__"? I suppose the include is harmless anyway. | |||
| msg261489 -(view) | Author: Martin Panter (martin.panter)* | Date: 2016-03-10 10:02 | |
Yes I would tend to think including <wincrypt.h> would be harmless on Windows, but I don’t have a native Windows to try it out on. Here is a proposed patch anyway. It would be good for someone to be able to confirm it doesn’t break the normal Windows build. | |||
| msg271599 -(view) | Author: Martin Panter (martin.panter)* | Date: 2016-07-29 03:53 | |
I think this one should be fairly safe; any breakage should be pretty obvious by watching the buildbots. | |||
| msg271600 -(view) | Author: Roundup Robot (python-dev) | Date: 2016-07-29 04:05 | |
New changeset11ed7c49f5df by Martin Panter in branch 'default':Issue#17596: MINGW: add wincrypt.h inPython/random.chttps://hg.python.org/cpython/rev/11ed7c49f5df | |||
| msg271601 -(view) | Author: Martin Panter (martin.panter)* | Date: 2016-07-29 04:13 | |
For the record, the first error without this patch is../Python/random.c:26:1: error: unknown type name 'HCRYPTPROV'According to <https://msdn.microsoft.com/en-us/library/windows/desktop/aa382471%28v=vs.85%29.aspx>, the header to use is <Wincrypt.h>, but we use lowercase <wincrypt.h> to avoid a problem with case sensitivity. | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:43 | admin | set | github: 61796 |
| 2016-07-29 04:13:30 | martin.panter | set | status: open -> closed resolution: fixed messages: +msg271601 stage: commit review -> resolved |
| 2016-07-29 04:05:14 | python-dev | set | nosy: +python-dev messages: +msg271600 |
| 2016-07-29 03:53:16 | martin.panter | set | messages: +msg271599 stage: patch review -> commit review |
| 2016-03-11 21:04:42 | martin.panter | link | issue17605 dependencies |
| 2016-03-10 10:02:32 | martin.panter | set | files: +MINGW-wincrypt.v3.patch components: + Windows versions: + Python 3.6, - Python 3.4 nosy: +martin.panter,paul.moore,tim.golden,Alex.Willmer,zach.ware,steve.dower messages: +msg261489 stage: patch review |
| 2014-08-03 06:11:29 | rpetrov | set | files: +0006-MINGW-add-wincrypt.h-in-Python-random.c.patch |
| 2013-03-31 20:54:57 | pitrou | set | nosy: +pitrou messages: +msg185672 |
| 2013-03-31 19:52:30 | rpetrov | create | |