➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2011-11-15 22:20 bypitrou, last changed2022-04-11 14:57 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| memhash.patch | pitrou,2011-11-15 22:20 | review | ||
| Messages (10) | |||
|---|---|---|---|
| msg147714 -(view) | Author: Antoine Pitrou (pitrou)* | Date: 2011-11-15 22:20 | |
This patch allows hashing of memoryviews, as discussed on python-dev. | |||
| msg147811 -(view) | Author: STINNER Victor (vstinner)* | Date: 2011-11-17 16:50 | |
Does memory_hash() reject non-contiguous memory?_Py_HashBytes() might be reused by unicode_hash() for PyUnicode_1BYTE_KIND. | |||
| msg147812 -(view) | Author: STINNER Victor (vstinner)* | Date: 2011-11-17 16:51 | |
Except these two minor nits, the patch looks good to me. | |||
| msg147813 -(view) | Author: Antoine Pitrou (pitrou)* | Date: 2011-11-17 16:57 | |
> Does memory_hash() reject non-contiguous memory?It should, since it checks the strides array.> _Py_HashBytes() might be reused by unicode_hash() for PyUnicode_1BYTE_KIND.I don't really see how unicode hashing should be related to byteshashing (even though apparently an (outdated?) test checks for that). | |||
| msg147814 -(view) | Author: Charles-François Natali (neologix)* | Date: 2011-11-17 17:55 | |
I'm not sure that the "register" storage class specifier is still relevant with modern compilers: I'm pretty sure gcc ignores it unless -O0, and I think I've read somewhere Microsoft's compiler ignores it too. | |||
| msg147815 -(view) | Author: Antoine Pitrou (pitrou)* | Date: 2011-11-17 18:00 | |
> I'm not sure that the "register" storage class specifier is still> relevant with modern compilers: I'm pretty sure gcc ignores it unless> -O0, and I think I've read somewhere Microsoft's compiler ignores it> too.I don't think so either. I was lazily moving the original code, but Icould remove those bits. | |||
| msg148080 -(view) | Author: Roundup Robot (python-dev) | Date: 2011-11-21 19:54 | |
New changeset215690b782f8 by Antoine Pitrou in branch 'default':Issue#13411: memoryview objects are now hashable when the underlying object is hashable.http://hg.python.org/cpython/rev/215690b782f8 | |||
| msg148082 -(view) | Author: Antoine Pitrou (pitrou)* | Date: 2011-11-21 19:57 | |
Fixed, thanks. | |||
| msg151451 -(view) | Author: Stefan Krah (skrah)* | Date: 2012-01-17 12:59 | |
Reopening as a reminder that it isn't fixed yet inhttp://hg.python.org/features/pep-3118 . | |||
| msg151955 -(view) | Author: Stefan Krah (skrah)* | Date: 2012-01-25 17:44 | |
Done in:http://hg.python.org/features/pep-3118/rev/508d5e3c579c | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:23 | admin | set | github: 57620 |
| 2012-01-25 17:44:39 | skrah | set | status: open -> closed resolution: remind -> fixed |
| 2012-01-25 17:44:16 | skrah | set | dependencies: -Problems with Py_buffer management in memoryobject.c (and elsewhere?) messages: +msg151955 |
| 2012-01-17 12:59:40 | skrah | set | messages: +msg151451 |
| 2012-01-17 12:58:03 | skrah | set | status: closed -> open dependencies: +Problems with Py_buffer management in memoryobject.c (and elsewhere?) resolution: fixed -> remind |
| 2011-11-21 19:57:02 | pitrou | set | status: open -> closed resolution: fixed messages: +msg148082 stage: patch review -> resolved |
| 2011-11-21 19:54:08 | python-dev | set | nosy: +python-dev messages: +msg148080 |
| 2011-11-17 18:00:57 | pitrou | set | messages: +msg147815 |
| 2011-11-17 17:55:56 | neologix | set | nosy: +neologix messages: +msg147814 |
| 2011-11-17 16:57:46 | pitrou | set | messages: +msg147813 |
| 2011-11-17 16:51:20 | vstinner | set | messages: +msg147812 |
| 2011-11-17 16:50:59 | vstinner | set | nosy: +vstinner messages: +msg147811 |
| 2011-11-16 03:36:45 | eric.snow | set | nosy: +eric.snow |
| 2011-11-15 22:26:44 | meador.inge | set | nosy: +meador.inge |
| 2011-11-15 22:20:43 | pitrou | create | |