Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Dec 5, 2022. It is now read-only.

Fix action bar color according to the theme selected.#109

Open
tralves wants to merge1 commit intonativescript-vue:master
base:master
Choose a base branch
Loading
fromtralves:master

Conversation

tralves
Copy link
Contributor

Fixes#98.

Even if in the future you remove thenativescript-theme-core (replacing withns-tailwind? ;) ), right now it is pretty confusing. I just lost an embarrassing amount of time because I picked the theme 'forest' and just assumed that the action bar color was coming from the theme...

Anyway, this is a small fix that I think improves the current template.

@rigor789
Copy link
Member

This is something I wanted to do, but haven't gotten around to doing yet. Ideally I'd like to make the theme optional, as for most projects I work on, I don't need it, and there is no easy way to opt-out currently.

What I'm thinking is adding conditions to only add thepage andaction-bar classes when there is a theme selected. Would you mind working on this, or should I give it a bit more thought and come up with something that should work better?

@tralves
Copy link
ContributorAuthor

I can do that. But then we also need to add anone option to the theme, right?

@rigor789
Copy link
Member

I can do that. But then we also need to add anone option to the theme, right?

Yes, that would be the plan to be able to select "none" and then no extra classes are added

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color Scheme : StatusBar and ActionBar color
2 participants
@tralves@rigor789

[8]ページ先頭

©2009-2025 Movatter.jp