Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FEATURE] Add consumeWhitespaceWithComments and redirect consumeWhitespace (backported)#670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ziegenberg wants to merge2 commits intoMyIntervals:v8.x
base:v8.x
Choose a base branch
Loading
fromziegenberg:add-comsume-whitespacewithcomment

Conversation

ziegenberg
Copy link
Contributor

@ziegenbergziegenberg commentedAug 25, 2024•
edited
Loading

HavingconsumeWhitespace also consumes comments, and returning them was unexpected. This also "deprecates" the consumeWhitespace method and announces a breaking change for 9.0.0.

ziegenberg added a commit to ziegenberg/PHP-CSS-Parser that referenced this pull requestAug 25, 2024
…space (MyIntervals#670)Having comsumeWhitespace also consume comments and returning them was unexpected.Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg added a commit to ziegenberg/PHP-CSS-Parser that referenced this pull requestAug 25, 2024
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenbergziegenbergforce-pushed theadd-comsume-whitespacewithcomment branch froma07190b tob92f7c3CompareAugust 25, 2024 17:10
ziegenberg added a commit to ziegenberg/PHP-CSS-Parser that referenced this pull requestAug 25, 2024
…space (MyIntervals#670)Having comsumeWhitespace also consume comments and returning them was unexpected.Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg added a commit to ziegenberg/PHP-CSS-Parser that referenced this pull requestAug 25, 2024
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenbergziegenbergforce-pushed theadd-comsume-whitespacewithcomment branch fromb92f7c3 to79b271fCompareAugust 25, 2024 17:11
@ziegenbergziegenberg changed the title[FEATURE] Add comsumeWhitespaceWithComments and redirect comsumeWhitespace[FEATURE] Add consumeWhitespaceWithComments and redirect consumeWhitespaceAug 25, 2024
…space (MyIntervals#670)Having comsumeWhitespace also consume comments and returning them was unexpected.Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenbergziegenbergforce-pushed theadd-comsume-whitespacewithcomment branch from79b271f tod53d9baCompareAugust 25, 2024 17:19
@ziegenbergziegenberg changed the title[FEATURE] Add consumeWhitespaceWithComments and redirect consumeWhitespace[FEATURE] Add consumeWhitespaceWithComments and redirect consumeWhitespace (backported)Aug 25, 2024
Copy link
Collaborator

@oliverkleeoliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Could you also add a test for the new method? (Copying and modifying the test for the other method should be fine.)

@ziegenberg
Copy link
ContributorAuthor

Thanks! Could you also add a test for the new method? (Copying and modifying the test for the other method should be fine.)

@ziegenbergziegenberg deleted the add-comsume-whitespacewithcomment branchAugust 25, 2024 21:19
@ziegenbergziegenberg restored the add-comsume-whitespacewithcomment branchAugust 25, 2024 21:19
@ziegenberg
Copy link
ContributorAuthor

Sorry, clicked the wrong buttons...

@oliverklee
Copy link
Collaborator

This should go intomain first. Would you be willing to create a new PR targetingmain? (If I switch the target of this PR, I fear that this would create a bunch of merge conflicts.)

@oliverklee
Copy link
Collaborator

And (as far as I see) as this isn't necessary for the bugfix (please correct me if I'm wrong) and does not provide any user-/developer facing new feature, I'd prefer this to go intomain only. Would you be okay with this,@ziegenberg?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@oliverkleeoliverkleeoliverklee requested changes

Assignees

@ziegenbergziegenberg

Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
@ziegenberg@oliverklee
[8]ページ先頭
©2009-2025 Movatter.jp