NotificationsYou must be signed in to change notification settings
Fork5.1k
Star55.5k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

fix(nuxt): add key to`.client` component placeholders#20093

Merged

danielroe merged 13 commits intonuxt:mainfromhuang-julien:fix/scopedIdClient

Apr 7, 2023

Merged

fix(nuxt): add key to`.client` component placeholders#20093

danielroe merged 13 commits intonuxt:mainfromhuang-julien:fix/scopedIdClient

Apr 7, 2023

Conversation

Copy link

Member

huang-julien commentedApr 4, 2023

🔗 Linked issue

resolve#20061

❓ Type of change

Hi 👋 this PR fix.client components root nodes missing scopeId by simply adding akey

📖 Documentation (updates to the documentation, readme or JSdoc annotations)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
🧹 Chore (updates to the build process or auxiliary tools and libraries)
�?️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

I have linked an issue or discussion.
I have updated the documentation accordingly.

fix(nuxt): force .client components root node to inherit scopeId

36395e2

Copy link

codesandboxbot commentedApr 4, 2023

�? Open in CodeSandboxWeb Editor |VS Code |VS Code Insiders

huang-julien marked this pull request as ready for review

April 4, 2023 22:39

danielroe requested a review fromantfu

April 5, 2023 09:55

Copy link

Member

antfu commentedApr 5, 2023

@huang-julien can you explain more about why adding a boolean key can help the scopeId?

Copy link

MemberAuthor

huang-julien commentedApr 5, 2023

it is just to completly reload the render.
My guess was that since the placeholder is adiv and the components root node is also adiv, vue does not set thev-data scope Id. We don't have the issue if the.client component renders aFragment or any other tags.

Copy link

Member

antfu commentedApr 6, 2023

Maybe we could assign a random(or fixed) key to the placeholder but not the rendered component?
So placeholder with key should already not be treat the same as the rendered component without key. There shouldn't be much difference in practice but I am a bit worried overriding thekey user might define, or causing the component to mount multiple times etc.