Movatterモバイル変換

Skip to content

zencoder/aws-sdk-rubyPublic

forked fromaws/aws-sdk-ruby

NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commit5b8d4b1

alkesh26

committed

Simple type fixes and method change

1. aws.rb Instead of !array.include?() we can use exclude more readable. Benchmarked these methods. The result is same almost.2. customizer.rb Since shape_name is not used we can use each_value.3. parse.rb This can be initialized to empty array and hash. Does setting nil in method call make some memory manipulation. Rest all files are simple typo fixes.

1 parenta258474 commit5b8d4b1Copy full SHA for 5b8d4b1

File tree

8 files changed

+9

-11

lines changed

aws-sdk-core
- bin
  - aws.rb
- lib
  - aws-sdk-core
    - api
      - customizer.rb
    - json
      - parser.rb
    - plugins
      - glacier_checksums.rb
  - seahorse
    - client
      - http
        headers.rb
      - logging
        formatter.rb
      - net_http
        handler.rb
    - model
      - shapes.rb

8 files changed

+9

-11

lines changed

`‎aws-sdk-core/bin/aws.rb‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`
`10`	`10`	`defenv_boolkey,default`
`11`	`11`	`ifENV.key?(key)`
`12`		`-!['0','false','no','off'].include?(ENV[key].downcase)`
	`12`	`+['0','false','no','off'].exclude?(ENV[key].downcase)`
`13`	`13`	`else`
`14`	`14`	`default`
`15`	`15`	`end`

`‎aws-sdk-core/lib/aws-sdk-core/api/customizer.rb‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ def reshape_members(member_regex, modifications)`
`47`	`47`	`ifmember_regex.is_a?(String)`
`48`	`48`	`member_regex=/^#{member_regex}$/`
`49`	`49`	`end`
`50`		`-@client_class.api.definition['shapes'].eachdo \|shape_name,shape\|`
	`50`	`+@client_class.api.definition['shapes'].each_valuedo \|shape\|`
`51`	`51`	`ifshape['members']`
`52`	`52`	`shape['members'].eachdo \|member_name,member_ref\|`
`53`	`53`	`ifmember_name.match(member_regex)`

`‎aws-sdk-core/lib/aws-sdk-core/json/parser.rb‎`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,17 +34,15 @@ def structure(structure, values, target = nil)`
`34`	`34`	`# @param [Array] values`
`35`	`35`	`# @param [Array, nil] target`
`36`	`36`	`# @return [Array]`
`37`		`-deflist(list,values,target=nil)`
`38`		`-target=[]iftarget.nil?`
	`37`	`+deflist(list,values,target=[])`
`39`	`38`	`values.each{ \|value\|target <<parse_shape(list.member,value)}`
`40`	`39`	`target`
`41`	`40`	`end`
`42`	`41`
`43`	`42`	`# @param [Seahorse::Model::Shapes::Map] map`
`44`	`43`	`# @param [Hash] values`
`45`	`44`	`# @return [Hash]`
`46`		`-defmap(map,values,target=nil)`
`47`		`-target={}iftarget.nil?`
	`45`	`+defmap(map,values,target={})`
`48`	`46`	`values.eachdo \|key,value\|`
`49`	`47`	`target[key]=parse_shape(map.value,value)`
`50`	`48`	`end`

`‎aws-sdk-core/lib/aws-sdk-core/plugins/glacier_checksums.rb‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ module Plugins`
`11`	`11`	# * `:upload_multipart_part`
`12`	`12`	`#`
`13`	`13`	# The `:upload_archive` and `:upload_multipart_part` operations
`14`		-# accept a `:checksum` requestparamter. If this param
	`14`	+# accept a `:checksum` requestparameter. If this param
`15`	`15`	`# is present, then the checksum is assumed to be the proper`
`16`	`16`	`# tree hash of the file to be uploaded. If this param is`
`17`	`17`	`# not present, then the required tree hash checksum will`

`‎aws-sdk-core/lib/seahorse/client/http/headers.rb‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ module Http`
`11`	`11`	`# headers[:Authorization] = 'Abc'`
`12`	`12`	`#`
`13`	`13`	`# headers.keys`
`14`		`-# #=> ['content-length', 'authorization']]`
	`14`	`+# #=> ['content-length', 'authorization']`
`15`	`15`	`#`
`16`	`16`	`# headers.values`
`17`	`17`	`# #=> ['100', 'Abc']`

`‎aws-sdk-core/lib/seahorse/client/logging/formatter.rb‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ module Client`
`5`	`5`	`moduleLogging`
`6`	`6`
`7`	`7`	`# A log formatter receives a {Response} object and return`
`8`		`-# a log message as a string.. When you construct a {Formatter}, you provide`
	`8`	`+# a log message as a string. When you construct a {Formatter}, you provide`
`9`	`9`	`# a pattern string with substitutions.`
`10`	`10`	`#`
`11`	`11`	`# pattern = ':operation :http_response_status_code :time'`

`‎aws-sdk-core/lib/seahorse/client/net_http/handler.rb‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ def initialize(bytes_expected, bytes_received)`
`24`	`24`	`# @api private`
`25`	`25`	`DNS_ERROR_MESSAGE='getaddrinfo: nodename nor servname provided, or not known'`
`26`	`26`
`27`		-# Raised when a {Handler}can not construct a `Net::HTTP::Request`
	`27`	+# Raised when a {Handler}cannot construct a `Net::HTTP::Request`
`28`	`28`	`# from the given http verb.`
`29`	`29`	`classInvalidHttpVerbError <StandardError;end`
`30`	`30`

`‎aws-sdk-core/lib/seahorse/model/shapes.rb‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ def shape_class(type)`
`34`	`34`	`if@types.key?(type)`
`35`	`35`	`@types[type]`
`36`	`36`	`else`
`37`		-raiseArgumentError,"unregisterd type `#{type}'"
	`37`	+raiseArgumentError,"unregistered type `#{type}'"
`38`	`38`	`end`
`39`	`39`	`end`
`40`	`40`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp