Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork366
feat: Implement ZEP 8 URL syntax support for zarr-python#3567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ianhi wants to merge26 commits intozarr-developers:mainChoose a base branch fromianhi:ian/jhamman/zep8
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Add comprehensive ZEP 8 URL parsing and resolution system- Implement StoreAdapter ABC for extensible storage adapters- Add built-in adapters for file, memory, S3, GCS, HTTPS schemes- Support pipe-chained URLs like s3://bucket/data.zip|zip:|zarr3:- Add URLSegment parsing with validation- Integrate with zarr.open_group and zarr.open_array APIs- Include demo script and comprehensive test suite- Pass all existing tests + 35 new ZEP 8-specific tests
…into feature/zep8-url-support
…into feature/zep8-url-support
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
needs release notesAutomatically applied to PRs which haven't added release notes
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of@jhamman's#3369 with addressing my review comments
Claude summary of the changes on top of Joe's PR:
Test Coverage: 167 tests passing (1 skipped), up from ~150 tests
Missing ZEP 8 Features Analysis
Based on the ZEP 8 specification, here are the adapter schemes defined vs. implemented:
✅ Currently Implemented (9 adapters)
❌ Missing from Spec (11 adapters)
Storage/Database Adapters:
Compression Adapters:
3. gzip: - Transparent gzip decompression
4. zstd: - Transparent zstd decompression
Data Format Adapters:
5. n5: - N5 format support
6. tiff:, jpeg:, png:, bmp:, avif:, webp: - Image format adapters
7. neuroglancer-precomputed: - Neuroglancer format
8. json: - JSON pointer access
Utility Adapters:
9. byte-range:start-end - Byte range extraction
10. ..: - Parent directory traversal (for relative URLs)
Other Missing Features:
implementation notes)