Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Deprecate group()#3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dstansby wants to merge3 commits intozarr-developers:main
base:main
Choose a base branch
Loading
fromdstansby:deprecate-group

Conversation

@dstansby
Copy link
Contributor

@dstansbydstansby commentedSep 5, 2025
edited
Loading

Recently#3406 was a bit of a tangle wheregroup() andcreate_group() had different behaviour - this was fixed by makinggroup() a simple wrapper ofcreate_group(), as intended.

To reduce this API surface, this PR deprecatesgroup(), advising users to use eithercreate_group() oropen_group(). The intent of these other functions is clearer, and it mirrors the methods on theGroup class, which does not have agroup() method.

I left in one test that usesgroup() to make sure it still works during the deprecation period.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented indocs/user-guide/*.rst
  • Changes documented as a new file inchanges/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actionsgithub-actionsbot added the needs release notesAutomatically applied to PRs which haven't added release notes labelSep 5, 2025
@d-v-b
Copy link
Contributor

👍

@github-actionsgithub-actionsbot removed the needs release notesAutomatically applied to PRs which haven't added release notes labelSep 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dstansby@d-v-b

[8]ページ先頭

©2009-2025 Movatter.jp