Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

allow roundtripping theBytesCodec#3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
keewis wants to merge7 commits intozarr-developers:main
base:main
Choose a base branch
Loading
fromkeewis:endian-roundtrip

Conversation

@keewis
Copy link
Contributor

@keewiskeewis commentedAug 30, 2025•
edited
Loading

closes#3416

Basically, we're changing the default forendian when constructingBytesCodec usingfrom_dict.

(I also renamedtest_endian.py totest_bytes.py as mentioned in#3416 (comment))

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented indocs/user-guide/*.rst
  • Changes documented as a new file inchanges/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actionsgithub-actionsbot added the needs release notesAutomatically applied to PRs which haven't added release notes labelAug 30, 2025
@github-actionsgithub-actionsbot removed the needs release notesAutomatically applied to PRs which haven't added release notes labelAug 30, 2025
@keewis
Copy link
ContributorAuthor

keewis commentedAug 30, 2025•
edited
Loading

looks like some tests actually relied on this behavior, i.e. choosing the default endian if none was specified for multi-byte dtypes (even though this technically violates the spec).

Since this might be potentially user facing (I'm not certain, but at leastvirtualizarr usesArrayV3Metadata directly) someone might be relying on this behavior?

What wecould do is start a deprecation cycle by checking for this inArrayV3Metadata.from_dict and warning, then adding the system default. I'll leave the decision to you.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BytesCodec'sendian does not roundtrip

2 participants

@keewis@d-v-b
[8]ページ先頭
©2009-2025 Movatter.jp