Commitf674236

authored

(feat): usenp.zeros for buffer creation withfill_value=0 (#3082)

* (feat): use `np.zeros` for buffer creation when possible* (fix): add comment and check* (chore): relnote

1 parent481550a commitf674236Copy full SHA for f674236

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Use:py:func:`numpy.zeros` instead of:py:func:`np.full` for a performance speedup when creating a `zarr.core.buffer.NDBuffer` with `fill_value=0`.

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,8 @@ def create(`
`154`	`154`	`order:Literal["C","F"]="C",`
`155`	`155`	`fill_value:Any\|None=None,`
`156`	`156`	`)->Self:`
`157`		`-iffill_valueisNone:`
	`157`	`+# np.zeros is much faster than np.full, and therefore using it when possible is better.`
	`158`	`+iffill_valueisNoneor (isinstance(fill_value,int)andfill_value==0):`
`158`	`159`	`returncls(np.zeros(shape=tuple(shape),dtype=dtype,order=order))`
`159`	`160`	`else:`
`160`	`161`	`returncls(np.full(shape=tuple(shape),fill_value=fill_value,dtype=dtype,order=order))`

Comments

(0)