Commit14b372c

authored

feature: update default config setting for async.concurrency from 10->64 (#3526)

1 parent9f69611 commit14b372cCopy full SHA for 14b372c

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ def enable_gpu(self) -> ConfigSet:`
`107`	`107`	`"order":"C",`
`108`	`108`	`"write_empty_chunks":False,`
`109`	`109`	`},`
`110`		`-"async": {"concurrency":10,"timeout":None},`
	`110`	`+"async": {"concurrency":64,"timeout":None},`
`111`	`111`	`"threading": {"max_workers":None},`
`112`	`112`	`"json_indent":2,`
`113`	`113`	`"codec_pipeline": {`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ def test_config_defaults_set() -> None:`
`54`	`54`	`"order":"C",`
`55`	`55`	`"write_empty_chunks":False,`
`56`	`56`	`},`
`57`		`-"async": {"concurrency":10,"timeout":None},`
	`57`	`+"async": {"concurrency":64,"timeout":None},`
`58`	`58`	`"threading": {"max_workers":None},`
`59`	`59`	`"json_indent":2,`
`60`	`60`	`"codec_pipeline": {`
`@@ -100,15 +100,15 @@ def test_config_defaults_set() -> None:`
`100`	`100`	`]`
`101`	`101`	`)`
`102`	`102`	`assertconfig.get("array.order")=="C"`
`103`		`-assertconfig.get("async.concurrency")==10`
	`103`	`+assertconfig.get("async.concurrency")==64`
`104`	`104`	`assertconfig.get("async.timeout")isNone`
`105`	`105`	`assertconfig.get("codec_pipeline.batch_size")==1`
`106`	`106`	`assertconfig.get("json_indent")==2`
`107`	`107`
`108`	`108`
`109`	`109`	`@pytest.mark.parametrize(`
`110`	`110`	`("key","old_val","new_val"),`
`111`		`- [("array.order","C","F"), ("async.concurrency",10,20), ("json_indent",2,0)],`
	`111`	`+ [("array.order","C","F"), ("async.concurrency",64,128), ("json_indent",2,0)],`
`112`	`112`	`)`
`113`	`113`	`deftest_config_defaults_can_be_overridden(key:str,old_val:Any,new_val:Any)->None:`
`114`	`114`	`assertconfig.get(key)==old_val`

Comments

(0)