- Notifications
You must be signed in to change notification settings - Fork62
feat: Add configuration run environment#48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
xuexb wants to merge3 commits intomasterChoose a base branch fromfeat/config
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coveralls commentedJan 21, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@yugasun 老铁看下大体上没毛病吧,现在就差测试用例和文档说明了。 |
Collaborator
yugasun commentedJan 24, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@xuexb 整体流程没问题,思路也很好,可不可以在重要流程地方把注释加上,方便阅读。 另外几点建议:
|
Open
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
先不要合并。
name字段,标识当前功能模块对应的配置名称,如:name: issue/autoLabel表示对应了配置文件里的issue.autoLabel,当然也在想配置里是不是也直接写这个 key 而不是多套一级,如:pullRequest/autoReviewRequest和pullRequest.autoReviewRequest的区别name排列,并循环所有的package.json配置开启的功能,去注册事件,注册时以空间名/仓库名@事件名,这样在触发时就可以无条件触发了,因为是以仓库为粒度了上面对应了:
事件回调参数说明:
github-bot/src/app.js
Lines 35 to 38 in4bdb7b5
pkg.config.github-bot.username/repo,via:github-bot/src/app.js
Lines 69 to 72 in4bdb7b5
pkg.config.github-bot.username/repo.pullRequest.autoReviewRequest