Before adding new features and new modules, please go to issues to submit the relevant feature description first.
Write good commit messages and use the same coding conventions as the rest of the project.
Please commit code to dev branch and we will merge into master branch in feature
Ensure your edited codes with four spaces instead of TAB.

增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

Arthapz added3 commits

November 1, 2025 21:23

fix(llvm) fix llvm builtins not linked on windows

7f40bd2

nfc(llvm) add a test for llvm builtins

56e8652

fix(llvm) set default runtimes for clang windows

5e77488

Copy link

Contributor

gemini-code-assistbot commentedNov 1, 2025

Summary of Changes

Hello@Arthapz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical linking issues for LLVM-based projects on Windows, specifically concerningcompiler-rt builtins andlibc++ libraries. It introduces robust mechanisms forxmake to correctly locate and link these components, ensuring proper compilation and execution. A new dedicated test case has been added to validate these fixes.

Highlights

New LLVM Compiler-RT Test: A new test projectllvm_compiler_rt has been added, includingmain.c which uses__int128 to verifycompiler-rt builtins, andtest.lua to automate its build and execution with the LLVM toolchain onxmake.
Enhanced LLVM Path Detection: New functions like_get_llvm_resourcedir and_get_llvm_compiler_win_rtdir_and_link were introduced inxmake/modules/core/tools/clang.lua to improve the detection of LLVM's resource, root, andcompiler-rt library directories, particularly for Windows environments.
Explicit Windows LLVM Linker Fixes: Thenf_runtime function inxmake/modules/core/tools/clang.lua now explicitly manageslibc++ include paths and forces the linking ofcompiler-rt builtins on Windows, addressing known issues with automatic linking in LLVM on this platform.
Expanded Compiler Runtime Tool Support: Thecompiler_runtime rule inxmake/rules/utils/compiler_runtime/xmake.lua has been updated to recognizeclang as a valid compiler when determining and applying default Visual Studio runtimes on Windows.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

gemini-code-assistbot reviewed

Nov 1, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request effectively addresses the issue of linking LLVM compiler runtime builtins on Windows. The changes are well-structured, introducing a new test case to validate the fix and refactoring the LLVM path discovery logic for better clarity and maintainability. The core of the fix, which involves correctly identifying the compiler-rt library and passing the necessary flags to the compiler and linker, appears to be sound. I've added a couple of minor comments regarding code style and indentation to align with the project's conventions.

tests/projects/c/llvm_compiler_rt/test.lua Outdated

		functionmain(t)
		localflags=""
		ifci_is_running()then
		flags="-vD"

Copy link

Contributor

gemini-code-assistbotNov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The indentation for this line is incorrect. The project's coding conventions, as mentioned in the pull request template, require using 4 spaces for indentation. This line currently uses 1 space.

    flags = "-vD"

xmake/modules/core/tools/clang.lua Outdated

Comment on lines 289 to 315

		bin=bindir,
		lib=libdir,
		cxxlib=cxxlibdir,
		include=includedir,
		cxxinclude=cxxincludedir,
		res=resdir,
		rt=rtdir,
		rtlink=rtlink }

Copy link

Contributor

gemini-code-assistbotNov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The indentation in this table definition appears to be using tabs, which violates the project's coding style of using 4 spaces for indentation. Please correct the indentation to use spaces for consistency.

                   bin = bindir,                   lib = libdir,                   cxxlib = cxxlibdir,                   include = includedir,                   cxxinclude = cxxincludedir,                   res = resdir,                   rt = rtdir,                   rtlink = rtlink }