- Notifications
You must be signed in to change notification settings - Fork40
Updated to makefile for new wolfHSM/docs dir#235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jackctj117 commentedDec 1, 2025
Need to wait forwolfSSL/wolfHSM#256 to be merged |
bigbrett left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@jackctj117 This PR should also remove this documentation source from the wolfHSM directory, no? We don't want two copies of the documentation source floating around.
Also ensure that the documentation builds and renders properly both locally and in our nightly job using the relocated source before this gets merged
jackctj117 commentedDec 2, 2025
Yes was waiting for the other PR to be merged before removing those directories so the nightly wouldn't fail |
bigbrett commentedDec 2, 2025
@jackctj117 its merged |
Uh oh!
There was an error while loading.Please reload this page.
bigbrett commentedDec 12, 2025
@jackctj117 thanks. Have you verified that the docs render properly? Specifically the client API doxygen as part of the manual? Just want a set of eyes on it before this merges and potentially breaks our customer-facing docs |
Uh oh!
There was an error while loading.Please reload this page.
This pull request updates the
wolfHSM/Makefileto improve documentation build robustness and support a transition to a new documentation source directory. The changes ensure the correct documentation source is used, handle symlinked repositories for local testing, and guarantee that the externalwolfhsmrepo is cloned before documentation is built. Overrides to setup targets are introduced to inject these dependencies.