This repository was archived by the owner on Mar 16, 2019. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork1.6k
Using SDK Version variables from root project#693
Open
rayronvictor wants to merge1 commit intowkh237:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Instead of assuming the `compileSdkVersion`, `targetSdkVersion`, etc, read it from the root project.Default `compileSdkVersion` and `targetSdkVersion` to the latest versions.Android Target API Level 26 will be required in August 2018.https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.htmlAnd the React Native team is already working on this:facebook/react-native#17741facebook/react-native#18095
Please read the project README, PRs here are useless :-) |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of assuming the
compileSdkVersion,targetSdkVersion, etc, read it from the root project.Default
compileSdkVersionandtargetSdkVersionto the latest versions.Android Target API Level 26 will be required in August 2018.
https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html
And the React Native team is already working on this:
facebook/react-native#17741
facebook/react-native#18095
Thank you for making a pull request ! Just a gentle reminder :)