Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/wagmiPublic

chore: update .connect to .mutate#4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
o-az wants to merge5 commits intowevm:main
base:main
Choose a base branch
Loading
fromo-az:o-az/connect-to-mutate

Conversation

@o-az
Copy link
Contributor

@o-azo-az commentedMay 26, 2025•
edited
Loading

useConnect():

  • deprecate.connect and.connectAsync,
  • add.mutate and.mutateAsync,
  • updates tests to usemutate,
  • updateconnect tomutate in docs for Vue and React

useDisconnect():

  • deprecate.disconnect and.disconnectAsync,
  • add.mutate and.mutateAsync,
  • updates tests to usemutate,
    • updatedisconnect tomutate in docs for Vue and React

@changeset-bot
Copy link

changeset-botbot commentedMay 26, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:ded2ee4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercelbot commentedMay 26, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
wagmi✅ Ready (Inspect)Visit Preview💬Add feedbackJun 8, 2025 6:09am

Copy link
Member

@tmmtmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! Ideally we could extend this in the following ways:

  • Remove'mutate' | 'mutateAsync' from being omitted from the query return type (React,Vue)
  • Add@deprecated comments to theXMutate andXMutateAsync type helpers (e.g.ConnectMutate andConnectMutateAsync)
  • Addmutate/mutateAsync for all mutation hooks (along with the above and@deprecated comments for named return methods)

You are welcome to work on this or I can merge you PR into another branch and do this when I get some time.

o-az reacted with thumbs up emoji
@o-azo-azforce-pushed theo-az/connect-to-mutate branch from05e353c toded2ee4CompareJune 8, 2025 06:04
@tmmtmm marked this pull request as draftJune 29, 2025 19:03
@tmmtmm marked this pull request as ready for reviewJune 29, 2025 19:18
@tmmtmm marked this pull request as draftJune 29, 2025 19:18
@tmmtmmforce-pushed themain branch 4 times, most recently fromdbb8093 to5937456CompareSeptember 19, 2025 17:26
@jxomjxomforce-pushed themain branch 2 times, most recently from27f0d04 to7d15f06CompareSeptember 24, 2025 22:39
@jxomjxom mentioned this pull requestOct 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tmmtmmtmm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@o-az@tmm
[8]ページ先頭
©2009-2025 Movatter.jp