Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork503
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
Hi, Actually The option can only be set to default or null. As many people use a different browser for development than for browsing it could be nice to have such choice. Cheers |
BetaWas this translation helpful?Give feedback.
All reactions
Replies: 12 comments
-
Hey, Any update about this? Cheers! |
BetaWas this translation helpful?Give feedback.
All reactions
-
The underlying package we use is I'd like to avoid adding a new configuration option for the browser, so I'm hesitant on adding this feature. |
BetaWas this translation helpful?Give feedback.
All reactions
-
Hey! Why not? It will not break anything, only add flexibility, which is always good 😄! Consider that peoples often use two browsers, it would be a nice feature to add:
Cheers |
BetaWas this translation helpful?Give feedback.
All reactions
-
It could be also useful for developer usingwebpack-bundle-analyzer in their library... |
BetaWas this translation helpful?Give feedback.
All reactions
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
To make it even better, I'll suggest to replaceopener withopen. |
BetaWas this translation helpful?Give feedback.
All reactions
-
Additional flexibility is a double-edged sword. It makes the API surface larger, making the tool harder to use as documentation grows longer. Adding new options also introduces maintenance burden as we will need to make sure the new feature does not accidentally break. We don't currently have the testing infrastructure for the So that is why I am not eagerly adding this feature. |
BetaWas this translation helpful?Give feedback.
All reactions
😕 1
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
I would be agree if it was a huge add, but it's just easy as passingbrowser argument fromwebpack-bundle-analyzer toopen. How could that break anything or make future that more complicated? I don't get it honestly... |
BetaWas this translation helpful?Give feedback.
All reactions
-
I would probably wait untilsindresorhus/open#116 is implemented. |
BetaWas this translation helpful?Give feedback.
All reactions
-
Thanks@sindresorhus, looks like that would indeed help. |
BetaWas this translation helpful?Give feedback.
All reactions
-
FWIW: Until/if this is supported, you can hack around it with a script that overrides e.g. I put this script named And it allows me to choose my browser in the |
BetaWas this translation helpful?Give feedback.
All reactions
-
Hi there, |
BetaWas this translation helpful?Give feedback.
All reactions
-
Might not be, maybe a dependency bump is needed with this feature. Feel free to create a PR :) |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1🎉 1
This discussion was converted from issue #216 on February 23, 2023 09:10.