- Notifications
You must be signed in to change notification settings - Fork51
Initial sensei configuration#151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -108,7 +108,7 @@ services: | |||
| environment: | |||
| API_URL: http://localhost:3000 | |||
| ports: | |||
| -5000:5000 | |||
| -4400:5000 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Revert to default ports (you can edit this on your data directory and/or soon via ENV variable#145 )
| ports: | ||
| - "5401:5401" | ||
| - "3100:3000" | ||
| - "3001:3001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this will conflict to Liquid port
An image should be publicly available wither Docker Hub or Github Packages to be able to merge this for the public |
Thansk for the heads up on the port thing. We've got a lot of ports going on here, so I'll ensure that. And yes, I'll make sure a docker hub or github packages is available. Honestly I had meant to PR this to master of my own fork rather than here until I had it a little further along, but here it is. Oops. Thanks for responding so quickly to the issues we were opening this morning! |
Ok, this currently works as-is. |
| @@ -119,7 +119,7 @@ services: | |||
| environment: | |||
| API_URL: http://localhost:3001 | |||
| ports: | |||
| -5001:5000 | |||
| -4401:5000 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Still, this is used in many tutorials already. Best to give a different one to new services introduced if possible
| @@ -53,6 +53,8 @@ func startAction(ctx *cli.Context) error { | |||
| servicesToRun = append(servicesToRun, "lnd") | |||
| // Core Lightning Network | |||
| servicesToRun = append(servicesToRun, "lightningd") | |||
| // Sensei | |||
| servicesToRun = append(servicesToRun, "sensei") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is Sensei capable to work without the frontend ie. only API/RPC? If Yes, may be worth running it also in CI mode (ie. under the isCI branch) so the Nigiri Github Action can offer CI testing using sensei
Uh oh!
There was an error while loading.Please reload this page.
This requires a homegrown docker container that is not quite ready to be published yet, but getting close.