Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: migrate to pnpm workspace#2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
9romise wants to merge8 commits intovuejs:master
base:master
Choose a base branch
Loading
from9romise:pnpm-workspace

Conversation

@9romise
Copy link
Contributor

@9romise9romise commentedNov 20, 2025•
edited
Loading

Additionally, is the team interested in migrating to a pnpm workspace? I believe this would allow .mts files in the docs directory to use the module type directly instead of following the root's commonjs configuration.

#2960 (comment)

ota-meshi reacted with thumbs up emoji
@changeset-bot
Copy link

changeset-botbot commentedNov 20, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:3cb4909

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@9romise9romise marked this pull request as draftNovember 20, 2025 17:11
@FloEdelmann
Copy link
Member

I'm a bit on the fence about this. This is an extra step for most contributors (which we can only expect to have plainnpm installed), only to simplify the CJS/ESM-specific code in the docs repo.

We could probably use proper ESM syntax there, too, by switching to the.mts/.js file extension, can we?

And in the long term, we'll probably switch over to ESM for the whole repo anyway (and generate CJS in the build step, which you introduced in#2916).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@9romise@FloEdelmann
[8]ページ先頭
©2009-2025 Movatter.jp