Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork684
feat: add TypeScript IntelliSense support with eslint-typegen#2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
changeset-botbot commentedJun 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please update to ESLint v9 in the dev dependencies, so we don't need to use--legacy-peer-deps
. This would also fix the Netlify deployment that is currently failing due to that peer dependency mismatch.
Updating that version is irrelevant for users of this package, as ESLint v8 is still supported as a peer dependency. We also run the tests in the CI with ESLint v8, so everything is well tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for the feedback :)
I initially anticipated that ESLint v9 would be a blocker for this issue, so I created a separateissue for the ESLint v9 upgrade.
However, I receivedadvice that eslint-typegen doesn't strictly require ESLint v9, and I was able to confirm it works locally with the current setup using--legacy-peer-deps
.
From a project perspective, which approach would you prefer ?
- ESLint v9 as blocker
Update ESLint v9 in (Upgrade ESLint from v8 to v9 #2756), then integrate eslint-typegen without--legacy-peer-deps
- Proceed with ESLint v8
Keep the current ESLint v8 setup and use--legacy-peer-deps
for eslint-typegen integration
I'm happy to proceed with whichever approach aligns 😄
Thank you for this PR! |
Summary
Add TypeScript IntelliSense support via
eslint-typegen
with ESM migration for ESLint v9.0+ compatibility.Changes
eslint-typegen
for TypeScript definitionseslint.config.js
toeslint.config.mjs
(required for eslint-typegen)--legacy-peer-deps
due to ESLint version requirementsBenefits
Screenshot
close#2757