Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add TypeScript IntelliSense support with eslint-typegen#2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
2nofa11 wants to merge1 commit intovuejs:master
base:master
Choose a base branch
Loading
from2nofa11:add/eslint-typegen

Conversation

2nofa11
Copy link

Summary

Add TypeScript IntelliSense support viaeslint-typegen with ESM migration for ESLint v9.0+ compatibility.

Changes

  • Integrateeslint-typegen for TypeScript definitions
  • Converteslint.config.js toeslint.config.mjs (required for eslint-typegen)
  • Install with--legacy-peer-deps due to ESLint version requirements
  • Update all imports to ESM format

Benefits

  • TypeScript IntelliSense for ESLint configurations
  • Modern ESLint v9.0+ compatibility
  • Improved developer experience with type safety

Screenshot

Before(No TypeScript Support)After(TypeScript IntelliSense Active)
No TypeScript SupportTypeScript IntelliSense Active

close#2757

FloEdelmann reacted with thumbs up emoji
@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJun 26, 2025
edited
Loading

⚠️ No Changeset found

Latest commit:73d68c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please update to ESLint v9 in the dev dependencies, so we don't need to use--legacy-peer-deps. This would also fix the Netlify deployment that is currently failing due to that peer dependency mismatch.

Updating that version is irrelevant for users of this package, as ESLint v8 is still supported as a peer dependency. We also run the tests in the CI with ESLint v8, so everything is well tested.

2nofa11 reacted with heart emoji
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the feedback :)

I initially anticipated that ESLint v9 would be a blocker for this issue, so I created a separateissue for the ESLint v9 upgrade.
However, I receivedadvice that eslint-typegen doesn't strictly require ESLint v9, and I was able to confirm it works locally with the current setup using--legacy-peer-deps.

From a project perspective, which approach would you prefer ?

  • ESLint v9 as blocker
    Update ESLint v9 in (Upgrade ESLint from v8 to v9 #2756), then integrate eslint-typegen without--legacy-peer-deps
  • Proceed with ESLint v8
    Keep the current ESLint v8 setup and use--legacy-peer-deps for eslint-typegen integration

I'm happy to proceed with whichever approach aligns 😄

@ota-meshi
Copy link
Member

Thank you for this PR!
Furthermore, can you make it so that we can provide rule types from this package using the low-level API?
https://github.com/antfu/eslint-typegen/blob/main/README.md#low-level-api

2nofa11 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FloEdelmannFloEdelmannFloEdelmann requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TypeScript IntelliSense support with eslint-typegen
3 participants
@2nofa11@ota-meshi@FloEdelmann

[8]ページ先頭

©2009-2025 Movatter.jp