Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork684
fix(require-default-prop): avoid requiring defaults for optional props not included in destructuring#2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
yuasa-engineer wants to merge2 commits intovuejs:masterChoose a base branch fromyuasa-engineer:fix/require-default-prop-optional-destructuring
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+77 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…s not included in destructuring- Only require default values for optional props that are explicitly destructured- Optional props not included in destructuring pattern are now ignored- Fixes regression introduced in v10.1.0 where all optional props required defaults
changeset-botbot commentedJun 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🦋 Changeset detectedLatest commit:88b94f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means?Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#2767
If this approach doesn't align with the project's direction, please don't hesitate to reject this proposal. In that case, you may also close the corresponding issue.
What type of PR is this?
bug fix / enhancement
What does this PR do? / Why do we need it?
This PR fixes a regression in the
vue/require-default-prop
rule introduced in v10.1.0. The rule was requiring default values for ALL optional props when using props destructuring, even if those props were not included in the destructuring pattern.Before this fix
After this fix
What changes did you make? (Give an overview)
Modified
lib/rules/require-default-prop.js
:utils.getPropsDestructure(node)
to get destructured props and check if optional prop existsUpdated test cases in
tests/lib/rules/require-default-prop.js
:Which issue(s) does this PR fix?
Fixes#2767
Related to#2725 and#2741
Additional context
This change maintains backward compatibility and only reduces false positive warnings. The rule continues to work as expected for:
withDefaults()
(still works)The fix specifically addresses the user feedback that the previous fix was too aggressive and made Vue 3.5's props destructuring unnecessarily verbose.