Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/docsPublic

feat: setup twoslash for codeblocks#2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
antfu wants to merge7 commits intovuejs:main
base:main
Choose a base branch
Loading
fromantfu:feat/twoslash

Conversation

@antfu
Copy link
Member

@antfuantfu commentedJan 15, 2024•
edited
Loading

This is working now, but with a few caveats:

Preview

image

Short-term

Long-term

  • __VUE_OPTIONS_API__: true is required at this moment becausefloating-vue is still using Options API
  • shamefully-hoist=true is required at this moment fortwoslash to resolve the types correctly

And later we need to revise code blocks across the docs to add thetwoslash flag.

sxzz, icarusgk, and 9romise reacted with thumbs up emojistafyniaksacha, sadeghbarati, and icarusgk reacted with hooray emojiposva and icarusgk reacted with rocket emoji
@netlify
Copy link

netlifybot commentedJan 15, 2024•
edited
Loading

✅ Deploy Preview forvuejs ready!

NameLink
🔨 Latest commitc417157
🔍 Latest deploy loghttps://app.netlify.com/sites/vuejs/deploys/65e72cc7e95a7e0008476cf4
😎 Deploy Previewhttps://deploy-preview-2668--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@antfuantfu marked this pull request as ready for reviewFebruary 6, 2024 14:25
@antfu
Copy link
MemberAuthor

I think it's ready now. The only thing is that if we should bring Options API or wait for Floating Vue to adopt to Composition API only

@NataliaTepluhina
Copy link
Member

@antfu thank you for working on this! Looks great ✨

Could you please resolve the conflicts? I'll merge the PR and addtwoslash to the codeblocks

@brc-dd
Copy link
Member

brc-dd commentedFeb 17, 2024•
edited
Loading

I'll release vitepress by tomorrow. It will have shiki@v1. We can remove resolutions from package.json here.

Also, is it possible to use the older code background with twoslash? github-dark's default background doesn't look nice with other stuff.

@yyx990803
Copy link
Member

Let's enable Options API then, it's ok for now until we have a version offloating-vue that is Composition API based.

antfu reacted with thumbs up emoji

@antfu
Copy link
MemberAuthor

Should be good to go now

@yyx990803
Copy link
Member

I think we need to be a bit selective on where to use these, let me take a pass on the rest of the docs so it doesn't become distractive.

antfu reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antfu@NataliaTepluhina@brc-dd@yyx990803
[8]ページ先頭
©2009-2025 Movatter.jp