- Notifications
You must be signed in to change notification settings - Fork506
feat: move all eslint-related stuff to main repo#875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
haoqunjiang wants to merge208 commits intovuejs:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
https://github.com/npm/cli/tree/v8.17.0#faq-on-branding`npm` should never be capitalized unless it is being displayed in a location that is customarily all-capitals (ex. titles on `man` pages).pnpm seems to prefer lower-case branding too.
So that esbuild can correctly analyze the module dependency graph whenthis package is bundled into other packages such as create-vue.
So that there won't be extraneous `default` property.Fixed prettierrc generation of default style guide.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Co-authored-by: Haoqun Jiang <haoqunjiang@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
We need them to be in module graph so that esbuild can correctly bundlethem, seevuejs/create-eslint-config@f822d2dThis is a breaking change as we can only support Node.js 16.14+by using this feature.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
It's becoming harder and harder to maintain `create-eslint-config`separately as the tooling space evolves. So I decided to merge it backto the main repo.The functionality remains mostly the same, except that we now explicitlygenerate an oxlint config file instead of passing options via CLI args.Previously I was adding `--ignore-path .gitignore` to oxlint commands,but it turns out `.gitignore` is automatically respected inside a gitrepo[^1]. So I skipped that part.The general idea of this refactoring is that each functionality shouldbe self-contained inside its own template folder, so that in the futurewe can test them independently or even publish them as separate packagesagain. Still a lot of work to do in that direction, but this is a start.[^1]:https://oxc.rs/docs/guide/usage/linter/cli.html#ignore-files
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It's becoming harder and harder to maintain
@vue/create-eslint-configseparately as the tooling space evolves. So I decided to merge it back to the main repo.The functionality remains mostly the same, except that we now explicitly generate an oxlint config file instead of passing options via CLI args.
Previously, I was adding
--ignore-path .gitignoreto oxlint commands, but it turns out.gitignoreis automatically respected inside a git repo1. So I skipped that part.The general idea of this refactoring is that each general feature should be self-contained inside its own template folder (
lintingandformattingin this PR, in parallel withtsconfigand other stuff), so that in the future we can test them independently or even publish them as separate packages again. Still a lot of work to do in that direction, but this is a start.The commit log is a bit messy because I used
git subtreeto keep all commit history fromhttps://github.com/vuejs/create-eslint-config/But after all the refactoring, I guess I would squash them on merging.
The commit history isn't that important in this case.
Footnotes
https://oxc.rs/docs/guide/usage/linter/cli.html#ignore-files↩