- Notifications
You must be signed in to change notification settings - Fork504
[feat] Added support for Bun#630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cexbrayat commentedJan 12, 2025
@mchao123 Thanks for the PR @haoqunjiang Is this something we want to support as an option and yet another feature to maintain? Or could we just add a note in the README instead (as, IIUC, this just requires users to use a specific tsconfig file?). |
haoqunjiang commentedJan 13, 2025
I'm open to add bun support considering it's low-effort. But I don't think we need yet another option to show to every user. User-agent detection should suffice. |
mchao123 commentedJan 25, 2025
Some people prefer to use yarn or pnpm to manage their project creation. |
haoqunjiang commentedJan 25, 2025
But I don’t think that’s a common enough use case for us to support. |
mchao123 commentedFeb 6, 2025
It's been a long time has there been an update on this?I always need to do some extra work after creating a project in order to adapt to bun, it would be great if this was supported at creation time, thank you guys. |
cexbrayat commentedFeb 6, 2025
@mchao123 I think the user-agent detection proposition from@haoqunjiang is a good one: not too much maintenance work, and notanother prompt for users. Feel free to ping us when you'll have reworked the PR 👍 |
mchao123 commentedFeb 6, 2025
Ok, I'll close this PR and finish this modification based on the latest branch again. |
mchao123 commentedFeb 6, 2025
I've made the change to show the runtime checkbox only when the user carries the parameter "--runtime".Maintaining a proprietary version of a package only requires creating a new directory in the others-runtime folder. |
mchao123 commentedFeb 10, 2025
Help reviewing the code, thanks!@cexbrayat |
Added support for Bun, added runtime selectors.
This is a tentative change that may require a review of the code.