- Notifications
You must be signed in to change notification settings - Fork101
Do not inheritAttrs on ModalContainer#454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
develth commentedOct 2, 2024
great - would fix annoying error |
genu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I hope this PR lands soon to make the Warnings go away! I appreciate the effort.
| defineOptions({ | ||
| inheritAttrs:false, | ||
| }) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR should contain only this change alone. The version updates are handled upon release/publish.
An explanation of the issue would helpful. Why does this need to be false?
viteplay/package.json Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We shouldn't have to bump these in this PR. ( See other comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because we're bumping version, we also get a new lock, which we don't want.
| "@vue-final-modal/nuxt":"workspace:1.0.3", | ||
| "vue-final-modal":"workspace:4.5.4", | ||
| "vue-final-modal":"workspace:4.5.5", | ||
| "vue3-drag-resize":"^2.0.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See other comments.
Actually I have no idea if it is necessary to have attributes on the ModalContainer. If not this PR should solve:#453