Commit2032707

authored

Unnecessary multiplication by 3 creates confusion

Dividing i and j by 3 respectively is enough for creating a unique key for the box. The extra multiplication by 3 creates confusion as it is first of all not explained in the video explanation. And also unecessary.

1 parent83fc2ee commit2032707Copy full SHA for 2032707

File tree

1 file changed

-2

lines changed

java
- 36-valid-sudoku.java

1 file changed

-2

lines changed

`‎java/36-valid-sudoku.java‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,10 +15,10 @@ public boolean isValidSudoku(char[][] board) {`
`15`	`15`
`16`	`16`
`17`	`17`	`//Check whether Box contains duplicate elements in it`
`18`		`-if(h1.contains("box"+ (i/3)*3 +j/3 +board[i][j])){`
	`18`	`+if(h1.contains("box"+ (i/3) +(j/3) +board[i][j])){`
`19`	`19`	`returnfalse;`
`20`	`20`	`}`
`21`		`-h1.add("box"+ (i/3)*3 +j/3 +board[i][j]);`
	`21`	`+h1.add("box"+ (i/3) +(j/3) +board[i][j]);`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2032707

File tree

1 file changed

1 file changed

`‎java/36-valid-sudoku.java‎`

0 commit comments