- Notifications
You must be signed in to change notification settings - Fork202
src/config/services/index.md: Improve wording#632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Please review carefully, as I'm quite new to Also note that after my changes it says "[the service] will be started with the same environmentvariables". I'm not 100% sure this is correct. But if it is, this wording is more precise IMO. |
ericonr commentedDec 24, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Looks good, but please fix the commit message to be the same as the PR title.
|
Done. |
vincele left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
AIUI, this bullet point refers to the clean "environment" of a process, and not to the concept of process state (e.g. running/failed/degraded/...).