NotificationsYou must be signed in to change notification settings
Fork118
Star914

Commitcfbc858

committed

Fixed#256 : [BUG] Scrolling Issue with iloc in Subset App

When iloc is selected in Subset app- Fixes incorrect indexing issue- Resolves scrollbar being fixed downwards, preventing number clicking and scrolling up.

1 parentfca3d9b commitcfbc858Copy full SHA for cfbc858

File tree

1 file changed

-3

lines changed

visualpython/js/m_apps
- Subset.js

1 file changed

-3

lines changed

`‎visualpython/js/m_apps/Subset.js‎`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -343,6 +343,9 @@ define([`
`343`	`343`	`$(this.wrapSelector('.select-row .vp-ds-select-box.left')).on('scroll',function(){`
`344`	`344`	`if($(this).scrollTop()+$(this).innerHeight()>=($(this)[0].scrollHeight-2)){`
`345`	`345`	`letscrollPos=$(this).scrollTop();`
	`346`	`+if(that.state.rowLimit>that.state.rowList.length){`
	`347`	`+return;// Prevents scroll from being fixed downwards`
	`348`	`+}`
`346`	`349`	`letstart=that.state.rowLimit;`
`347`	`350`	`letend=start+10;`
`348`	`351`	`letsubsetVariable=com_util.formatString('{0}.iloc[{1}:{2}]',that.state.pandasObject,start,end);`
`@@ -361,9 +364,9 @@ define([`
`361`	`364`	`rowList=rowList.map(function(x){`
`362`	`365`	`return{`
`363`	`366`	`...x,`
`364`		`-label:x.location+'',`
`365`		`-value:x.location+'',`
`366`		`-code:x.location+'',`
	`367`	`+label:x.label+'',`
	`368`	`+value:x.value+'',`
	`369`	`+code:x.code+'',`
`367`	`370`	`};`
`368`	`371`	`});`
`369`	`372`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitcfbc858

File tree

1 file changed

1 file changed

`‎visualpython/js/m_apps/Subset.js‎`

0 commit comments