Commitc42f12b

minjk-bl

committed

Change scroll operation on MenuFrame when user clicks menu category

1 parentd3a25ca commitc42f12bCopy full SHA for c42f12b

File tree

+17

-9

lines changed

+17

-9

lines changed

Lines changed: 10 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,18 +57,18 @@`
`57`	`57`	`padding:05px5px5px;`
`58`	`58`	`box-sizing: border-box;`
`59`	`59`	`}`
`60`		`-.vp-menu-body>div:nth-child(2) {`
	`60`	`+/*.vp-menu-body > div:nth-child(2) {`
`61`	`61`	`margin-top: 50px;`
`62`		`-}`
	`62`	`+} */`
`63`	`63`	`.vp-menu-search-div {`
`64`	`64`	`box-sizing: border-box;`
`65`	`65`	`padding:10px010px0px;`
`66`		`-position:absolute;`
`67`		`-width:calc(100%-10px);`
	`66`	`+position:relative;`
	`67`	`+width:100%;`
`68`	`68`	`background: white;`
`69`	`69`	`}`
`70`	`70`	`.vp-menu-search-box {`
`71`		`-width:calc(100%-50px);`
	`71`	`+width:calc(100%-45px);`
`72`	`72`	`height:30px;`
`73`	`73`	`background:#FFFFFF;`
`74`	`74`	`border:0.25px solid#e4e4e4;`
`@@ -83,14 +83,14 @@`
`83`	`83`	`width:20px;`
`84`	`84`	`height:20px;`
`85`	`85`	`position: relative;`
`86`		`-right:32px;`
	`86`	`+right:30px;`
`87`	`87`	`}`
`88`	`88`	`.vp-board-toggle-icon {`
`89`	`89`	`width:26px;`
`90`	`90`	`height:26px;`
`91`	`91`	`position: absolute;`
`92`	`92`	`top:11px;`
`93`		`-right:8px;`
	`93`	`+right:4px;`
`94`	`94`	`cursor: pointer;`
`95`	`95`	`background-image: url(../img/toggleNote.svg);`
`96`	`96`	`background-position: center;`
`@@ -105,6 +105,9 @@`
`105`	`105`	`.vp-board-toggle-icon:hover {`
`106`	`106`	`background-image: url(../img/toggleNote.svg);`
`107`	`107`	`}`
	`108`	`+.vp-menugroup-list {`
	`109`	`+height:calc(100%-45px);`
	`110`	`+}`
`108`	`111`
`109`	`112`	`.vp-menu-footer {`
`110`	`113`	`width:100%;`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,12 +48,15 @@`
`48`	`48`	`</div>`
`49`	`49`	`</div>`
`50`	`50`	`<!-- Menu Body -->`
`51`		`-<divid="vp_menuBody"class="vp-menu-body vp-scrollbar">`
	`51`	`+<divid="vp_menuBody"class="vp-menu-body">`
`52`	`52`	`<divclass="vp-menu-search-div">`
`53`	`53`	`<inputid="vp_menuSearchBox"class="vp-input vp-menu-search-box"type="text"placeholder="Search">`
`54`	`54`	`<imgclass="vp-menu-search-icon"src="/nbextensions/visualpython/img/search.svg"/>`
`55`	`55`	`<divid="vp_toggleBoard"class="vp-board-toggle-icon"title="Show VP Note"></div>`
`56`	`56`	`</div>`
	`57`	`+<divclass="vp-menugroup-list vp-scrollbar">`
	`58`	`+`
	`59`	`+</div>`
`57`	`60`	`</div>`
`58`	`61`	`<!-- Menu Footer -->`
`59`	`62`	`<divid="vp_menuFooter"class="vp-menu-footer">`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ define([`
`252`	`252`	`menuLibraries&&menuLibraries.forEach(item=>{`
`253`	`253`	`if(item.type=='package'){`
`254`	`254`	`// packages : MenuGroup`
`255`		`-varmenuGroup=newMenuGroup($('#vp_menuBody'),item);`
	`255`	`+varmenuGroup=newMenuGroup($('.vp-menugroup-list'),item);`
`256`	`256`	`if(item.item){`
`257`	`257`	`that.renderMenuItem(menuGroup);`
`258`	`258`	`}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,8 @@ define([`
`39`	`39`	`bodyTag.hide();`
`40`	`40`	`}else{`
`41`	`41`	`bodyTag.show();`
	`42`	`+// scroll to view`
	`43`	`+$(target)[0].scrollIntoView({behavior:"smooth",block:"start"});`
`42`	`44`	`}`
`43`	`45`	`evt.stopPropagation();`
`44`	`46`	`}`

Comments

(0)