Commitc154b51

minjk-bl

committed

CHROME: added parentSelector for popup and file navigation

1 parentfeba20d commitc154b51Copy full SHA for c154b51

File tree

+10

-2

lines changed

+10

-2

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,12 @@ define([`
`47`	`47`	`constructor(extensionType='notebook',initialData={}){`
`48`	`48`	`// initial mode`
`49`	`49`	`this.extensionType=extensionType;`
	`50`	`+this.parentSelector='body';`
	`51`	`+if(extensionType==='notebook'){`
	`52`	`+this.parentSelector='#site';`
	`53`	`+}elseif(extensionType==='chrome'){`
	`54`	`+this.parentSelector='.notebook-horizontal';`
	`55`	`+}`
`50`	`56`	`// initial configuration`
`51`	`57`	`this.data={`
`52`	`58`	`// Configuration`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ define([`
`47`	`47`	`*@param {Object} state { type, extensions, finish ... }`
`48`	`48`	`*/`
`49`	`49`	`constructor(state){`
`50`		`-super($('#site'),state);`
	`50`	`+super($(vpConfig.parentSelector),state);`
`51`	`51`	`/**`
`52`	`52`	`* state.type open / save`
`53`	`53`	`* state.extensions extensions list`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,9 @@ define([`
`41`	`41`	`*/`
`42`	`42`	`classPopupComponentextendsComponent{`
`43`	`43`	`constructor(state={config:{id:'popup',name:'Popup title',path:'path/file'}},prop={}){`
`44`		`-super($('#site'),state,prop);`
	`44`	`+// CHROME: FIXME: #site -> .notebook-vertical`
	`45`	`+// super($('#site'), state, prop);`
	`46`	`+super($(vpConfig.parentSelector),state,prop);`
`45`	`47`	`}`
`46`	`48`
`47`	`49`	`_init(){`

Comments

(0)