NotificationsYou must be signed in to change notification settings
Fork118
Star914

Commit724cf44

minjk-bl

committed

Edit auto-update on JupyterLab and Fix default-state of open vp initially on Jupyter Notebook

1 parent1004447 commit724cf44Copy full SHA for 724cf44

File tree

1 file changed

-10

lines changed

visualpython/js/com
- com_Config.js

1 file changed

-10

lines changed

`‎visualpython/js/com/com_Config.js‎`

Lines changed: 6 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,6 @@ define([`
`208`	`208`	`vp_config_version:'1.0.0',`
`209`	`209`	`vp_signature:'VisualPython',`
`210`	`210`	`vp_position:{},`
`211`		`-// CHROME: default to display vp`
`212`	`211`	`vp_section_display:false,`
`213`	`212`	`vp_note_display:false,`
`214`	`213`	`vp_menu_width:Config.MENU_MIN_WIDTH,`
`@@ -226,8 +225,6 @@ define([`
`226`	`225`
`227`	`226`	`// merge default config`
`228`	`227`	`$.extend(true,this.defaultConfig,this.metadataSettings);`
`229`		`-`
`230`		`-console.log('test 1',this.defaultConfig);`
`231`	`228`	`}`
`232`	`229`
`233`	`230`	`_readUserCommandList(){`
`@@ -487,15 +484,15 @@ define([`
`487`	`484`	`that._checkMounted().then(function(){`
`488`	`485`	`that._readFromColab(configKey).then(function(result){`
`489`	`486`	`letdata=result;`
`490`		`-if(data==undefined\|\|Object.keys(data).length===0){`
	`487`	`+if(data==undefined\|\|(datainstanceofObject&&Object.keys(data).length===0)){`
`491`	`488`	`resolve(data);`
`492`	`489`	`return;`
`493`	`490`	`}`
`494`	`491`	`if(dataKey==''){`
`495`	`492`	`resolve(data);`
`496`	`493`	`return;`
`497`	`494`	`}`
`498`		`-if(datainstanceofObject&&Object.keys(data).length===0){`
	`495`	`+if(datainstanceofObject&&Object.keys(data).length>0){`
`499`	`496`	`resolve(data[dataKey]);`
`500`	`497`	`return;`
`501`	`498`	`}`
`@@ -511,15 +508,15 @@ define([`
`511`	`508`	`// LAB: use local .visualpython files`
`512`	`509`	`that._readFromLab(configKey).then(function(result){`
`513`	`510`	`letdata=result;`
`514`		`-if(data==undefined\|\|Object.keys(data).length===0){`
	`511`	`+if(data==undefined\|\|(datainstanceofObject&&Object.keys(data).length===0)){`
`515`	`512`	`resolve(data);`
`516`	`513`	`return;`
`517`	`514`	`}`
`518`	`515`	`if(dataKey==''){`
`519`	`516`	`resolve(data);`
`520`	`517`	`return;`
`521`	`518`	`}`
`522`		`-if(datainstanceofObject&&Object.keys(data).length===0){`
	`519`	`+if(datainstanceofObject&&Object.keys(data).length>0){`
`523`	`520`	`resolve(data[dataKey]);`
`524`	`521`	`return;`
`525`	`522`	`}`
`@@ -787,7 +784,7 @@ define([`
`787`	`784`	`letnowDate=newDate();`
`788`	`785`	`this.getData('version_timestamp','vpcfg').then(function(data){`
`789`	`786`	`letdoCheckVersion=false;`
`790`		`-vpLog.display(VP_LOG_TYPE.LOG,'Checking its version timestamp... : '+data);`
	`787`	`+vpLog.display(VP_LOG_TYPE.DEVELOP,'Checking its version timestamp... : '+data);`
`791`	`788`	`if(data==undefined\|\|(datainstanceofObject&&Object.keys(data).length===0)){`
`792`	`789`	`// no timestamp, check version`
`793`	`790`	`doCheckVersion=true;`
`@@ -801,7 +798,6 @@ define([`
`801`	`798`
`802`	`799`	`if(diff>=1){`
`803`	`800`	`// if More than 1 day passed, check version`
`804`		`-vpLog.display(VP_LOG_TYPE.LOG,'timestamp diff : '+diff);`
`805`	`801`	`doCheckVersion=true;`
`806`	`802`	`}`
`807`	`803`	`}`
`@@ -962,7 +958,7 @@ define([`
`962`	`958`	`/**`
`963`	`959`	`* Version`
`964`	`960`	`*/`
`965`		`-Config.version="2.3.2";// TEST:`
	`961`	`+Config.version="2.3.2";`
`966`	`962`
`967`	`963`	`/**`
`968`	`964`	`* Type of mode`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit724cf44

File tree

1 file changed

1 file changed

`‎visualpython/js/com/com_Config.js‎`

0 commit comments