Commit15b6bba

committed

fix(tag): improve tag resolution handling

The handling is similar, but the error message makes clearwhat is happening, and what can be done to handle such a case.Related togitpython-developers#561

1 parentc823d48 commit15b6bbaCopy full SHA for 15b6bba

File tree

1 file changed

-2

lines changed

git/refs
- tag.py

1 file changed

-2

lines changed

`‎git/refs/tag.py‎`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,14 +22,17 @@ class TagReference(Reference):`
`22`	`22`
`23`	`23`	`@property`
`24`	`24`	`defcommit(self):`
`25`		`-""":return: Commit object the tag ref points to"""`
	`25`	`+""":return: Commit object the tag ref points to`
	`26`	`+`
	`27`	`+ :raise ValueError: if the tag points to a tree or blob"""`
`26`	`28`	`obj=self.object`
`27`	`29`	`whileobj.type!='commit':`
`28`	`30`	`ifobj.type=="tag":`
`29`	`31`	`# it is a tag object which carries the commit as an object - we can point to anything`
`30`	`32`	`obj=obj.object`
`31`	`33`	`else:`
`32`		`-raiseValueError("Tag %s points to a Blob or Tree - have never seen that before"%self)`
	`34`	`+raiseValueError(("Cannot resolve commit as tag %s points to a %s object - "`
	`35`	++"use the `.object` property instead to access it")% (self,obj.type))
`33`	`36`	`returnobj`
`34`	`37`
`35`	`38`	`@property`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit15b6bba

File tree

1 file changed

1 file changed

`‎git/refs/tag.py‎`

0 commit comments