- Notifications
You must be signed in to change notification settings - Fork188
fix(state): exit pip mode#1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
pzanella wants to merge1 commit intovidstack:mainChoose a base branch frompzanella:fix/exit-pip
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Fixes picture-in-picture mode getting stuck during Next.js route navigation
Closes#1723
Description:
This PR resolves an issue where the media player would remain stuck in picture-in-picture (PiP) mode when navigating between pages in Next.js applications. The problem occurred because the original implementation relied solely on the provider's PiP API, which could become null during component destruction, causing the exit operation to fail silently.
Key Changes:
Enhanced PiP Exit Strategy: Implemented a multi-layered fallback approach in
exitPictureInPicture():document.exitPictureInPicture()API (most reliable)webkitSetPresentationMode('inline')Improved Error Handling: Added proper error logging using the existing logger infrastructure instead of silent failures
Cross-browser Compatibility: Added support for WebKit browsers (Safari) that use proprietary PiP APIs
Technical Implementation:
The solution wraps the exit logic in a try-catch block and implements three sequential fallback strategies to ensure PiP mode is properly exited even when:
This ensures clean state management and prevents the player from getting stuck in PiP mode during navigation.
Ready?
Yes, this PR is ready for review. The implementation follows existing code patterns, uses proper error handling, and maintains backward compatibility.
Anything Else?
Testing Scenarios:
Impact: