- Notifications
You must be signed in to change notification settings - Fork2.7k
added ability to override error-controller error handling via HlsConfig#7658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
| consthls=this.hls; | ||
| // If the error is handled by onErrorHandler or is fatal, do not proceed with error recovery | ||
| if(hls.config.onErrorHandler?.(data)||data.fatal){ | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This still won't stop propagation through other event listeners, nor should we attempt to make it. Addingresolved: true to data is how error handling signals that other components do not need to take any further action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just updated the PR with this.
This PR will allow for error-controller to defer handling of errors via HlsConfig.
Why is this Pull Request needed?
In certain cases, you may not want hls.js to raise a fatal when an error occurs OR you would like to handle an error manually. An example would be if WebVTT subtitles are in use and the player enters an adbreak (where no subtitle's exist) OR there is a CDN issue where WebVTT files are unavailable, the developer may want playback to continue rather than raising a fatal error.
Are there any points in the code the reviewer needs to double check?
Ensure that callback functions & documentation is clear.
Resolves issues:
N/A => I will create an issue depending on feedback to this draft PR.
Checklist