- Notifications
You must be signed in to change notification settings - Fork2.7k
Support playback for elementary audio stream encrypted using Sample-AES#7479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
robwalch left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you include an example of clear-key encrypted content that requires / demonstrates this change?
src/demux/audio/aacdemuxer.ts Outdated
| } | ||
| } | ||
| asyncdemuxSampleAes( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do not use theasync keyword - Babel adds theregenerator lib to the ES5 output to support it, which increases the bundle size significantly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Opened#7480 so that this is caught by the linter:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for the tips! I've removed it in370b905
This PR will...
Allow
hls.jsto decrypt Elementary Audio Stream of Sample-AES.Why is this Pull Request needed?
Aside of traditional MPEG-TS based container, Sample-AES allows carry raw encrypted audio data.
Reference:
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist