- Notifications
You must be signed in to change notification settings - Fork47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Devex: Fix a bunch of typescript errors#5893
Draft
Mwindo wants to merge231 commits intoustaxcourt:stagingChoose a base branch fromflexion:devex-typescript-errors
base:staging
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… changes to upsertCases.ts
… just use upsertCases), and adding petitioners to a case in getCaseByDocketNumber
…do is to go through and clean up the files, extracting relations as needed
…or duplicates and finish statistics schema stuff
…ractor and move 'formatting' and 'decorating' logic to either CaseFactory or constructors for the appropriate entities
…r table, which should only include information relevant to login/permissions/etc.
…yDocketNumber), and implement the logic of caseFilter.sealedCaseFormatter as the constructor for RestrcitedCase, removing sealedCaseFormatter in the process
… so that we can actually create a case
…mber; remove apparently unused endpoint/interactor getCaseForPublicDocketNumberSearch
… involve users) and 'finish' getCaseByDocketNumber
…pper function, and rename mapper functions for clarity
…es are always associated with their parent statistic and 2) maintaining the order of penalties
…for statistics instead of magic numbers
…ing order of statistics for same year; will update if it turns out we do need to enforce this after all
…efetching practitioners
…metimes expecting null)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of 10502 to avoid merge conflicts.
During downtime, I'll just be going through and getting rid of as many type errors as I can. We have them broken up by the type of type error in the devex tickets, but I am not sure how useful that is. For example, fixing the scanner-related errors all at once is easier than fixing error type x, error type y, etc., which intersect files randomly.