Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

xml attribute locations#1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
jurgenvinju wants to merge6 commits intomain
base:main
Choose a base branch
Loading
fromxml-attribute-locations
Draft

Conversation

@jurgenvinju
Copy link
Member

  • Using jsoup 1.17.1 which can track attribute locations
  • minor refactoring for clarity

Copy link
Member

@DavyLandmanDavyLandman left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, feel free to merge this after you've got the build to succeed.

would be nice if we could add some tests? but otherwise: all good.

@jurgenvinju
Copy link
MemberAuthor

jurgenvinju commentedNov 28, 2023•
edited
Loading

Thanks!

  • Found a bug in the jsoup implementation, so I'm waiting for that fix and a release.
  • If we ever want to lift thesenode to parse trees we also need the locations of the names of the attributes. So I'm thinking to extend thesrcs map tomap[str label, tuple[loc name, loc val] src]

@jurgenvinju
Copy link
MemberAuthor

Seejhy/jsoup#1933

@linuswagner
Copy link

linuswagner commentedSep 20, 2025•
edited
Loading

@jurgenvinju the features in the PR are not part of main yet, right? These would be required in order for me to publish the XML M3.

@linuswagner
Copy link

linuswagner commentedSep 20, 2025•
edited
Loading

I checked the version in this branch. It would be super helpful to also have asrc for the name of the tag (at the momentNode.src return the entire tag) and for "value" of the tag (<tag>VALUE</tag>)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@DavyLandmanDavyLandmanDavyLandman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jurgenvinju@linuswagner@DavyLandman
[8]ページ先頭
©2009-2025 Movatter.jp