BinaryExpression nodes where both left and right are MemberExpression are not checked,
a === null || a.b !== foo.three; // bug: should be flagged/fixable, is not
and CallExpression nodes whose callee is a MemberExpression are not treated as MemberExpression.
a === null || a.b !== a.c();

Fix

IntroducedMemberBasedExpression, which covers botha.b anda.b().
Addedunknown to theyoda enum

Logic foryoda: unknown

ForBinaryExpression nodes where both sides areMemberBasedExpression, setyoda tounknown.
- e.g.,a.b != a.c,a.b != c.d
Whenyoda isunknown and both sides are subsets of theprevious chain, skip the transformation inanalyzeChain.

mdm317 added3 commits

December 10, 2025 15:42

add test

ddf1e85

improve last chain operand with MemberExpression lhs/rhs

12cf92c

fix: lint

2838efc

Copy link

Contributor

typescript-eslintbot commentedDec 10, 2025

Thanks for the PR,@mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedDec 10, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`2838efc`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/69396cf79b4d87000864b910
😎 Deploy Preview	https://deploy-preview-11835--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 85 (🔴 down 12 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedDec 10, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit2838efc

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 12s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 17s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 9s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	20s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	10s	View ↗
`nx run types:build`	✅ Succeeded	2s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-12-10 13:04:03 UTC

Copy link

codecovbot commentedDec 10, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is96.33028% with4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.55%. Comparing base (dd96947) to head (2838efc).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/convert.ts	0.00%	3 Missing⚠️
packages/type-utils/src/predicates.ts	0.00%	1 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11835      +/-   ##==========================================+ Coverage   90.53%   90.55%   +0.01%==========================================  Files         523      523                Lines       53096    53140      +44       Branches     8838     8846       +8     ==========================================+ Hits        48073    48122      +49+ Misses       5010     5005       -5  Partials       13       13

Flag	Coverage Δ
unittest	`90.55% <96.33%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...lugin/src/rules/consistent-generic-constructors.ts	`97.46% <100.00%> (-0.02%)`	⬇️
...s/eslint-plugin/src/rules/no-dupe-class-members.ts	`100.00% <100.00%> (ø)`
...ges/eslint-plugin/src/rules/no-misused-promises.ts	`99.12% <100.00%> (-0.01%)`	⬇️
packages/eslint-plugin/src/rules/no-redeclare.ts	`98.57% <100.00%> (-0.01%)`	⬇️
packages/eslint-plugin/src/rules/no-type-alias.ts	`100.00% <100.00%> (ø)`
...slint-plugin/src/rules/prefer-namespace-keyword.ts	`100.00% <100.00%> (ø)`
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`98.27% <100.00%> (-0.01%)`	⬇️
.../rules/prefer-optional-chain-utils/analyzeChain.ts	`100.00% <100.00%> (ø)`
...efer-optional-chain-utils/gatherLogicalOperands.ts	`100.00% <100.00%> (ø)`
...ages/eslint-plugin/src/rules/unified-signatures.ts	`94.26% <100.00%> (-0.07%)`	⬇️
... and6 more

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mdm317 marked this pull request as ready for review

December 10, 2025 13:09

Labels

None yet

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [prefer-optional-chain] handle MemberExpression in final chain position#11835

Are you sure you want to change the base?

fix(eslint-plugin): [prefer-optional-chain] handle MemberExpression in final chain position#11835

Uh oh!