Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: check variable declaration syntax error against tsNode#11778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
fisker wants to merge12 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromfisker:variable-declare-check

Conversation

@fisker
Copy link
Contributor

@fiskerfisker commentedNov 23, 2025•
edited
Loading

PR Checklist

Overview

Same as#11777

The syntax check should always check against TS node instead of ESTree node before convert, prepare for#11695

No logic changes, just refactor.

Note: this contains changes from#11777, but fixed bothVariableDeclaration,VariableDeclarationList, andVariableStatement.

If smaller changes are preferred, I'll rebase after#11777 gets merged.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedNov 23, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita7fdcfc
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/692db20651be9200083df7c4
😎 Deploy Previewhttps://deploy-preview-11778--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedNov 23, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commita7fdcfc

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 11sView ↗
nx run-many -t lint✅ Succeeded3m 15sView ↗
nx run-many -t typecheck✅ Succeeded1m 55sView ↗
nx test typescript-estree --coverage=false✅ Succeeded21sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx run types:build✅ Succeeded2sView ↗
nx run generate-configs✅ Succeeded6sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-12-01 15:32:27 UTC

@codecov
Copy link

codecovbot commentedNov 23, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is40.50633% with47 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.55%. Comparing base (5ac66a6) to head (a7fdcfc).

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts40.50%47 Missing⚠️

❌ Your patch check has failed because the patch coverage (40.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11778      +/-   ##==========================================+ Coverage   90.53%   90.55%   +0.01%==========================================  Files         523      523                Lines       53097    53105       +8       Branches     8838     8839       +1     ==========================================+ Hits        48074    48088      +14+ Misses       5010     5004       -6  Partials       13       13
FlagCoverage Δ
unittest90.55% <40.50%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-estree/src/convert.ts31.29% <40.50%> (+0.39%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fiskerfisker marked this pull request as ready for reviewNovember 23, 2025 08:06
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesNov 24, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems reasonable to me, thanks!

+1 to merging in#11777 first.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelNov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp